From patchwork Wed Oct 2 14:35:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tariq Toukan X-Patchwork-Id: 1170708 X-Patchwork-Delegate: shemminger@vyatta.com Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=mellanox.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 46jzG90YRPz9sDB for ; Thu, 3 Oct 2019 00:36:01 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728171AbfJBOf6 (ORCPT ); Wed, 2 Oct 2019 10:35:58 -0400 Received: from mail-il-dmz.mellanox.com ([193.47.165.129]:38629 "EHLO mellanox.co.il" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728112AbfJBOf5 (ORCPT ); Wed, 2 Oct 2019 10:35:57 -0400 Received: from Internal Mail-Server by MTLPINE1 (envelope-from tariqt@mellanox.com) with ESMTPS (AES256-SHA encrypted); 2 Oct 2019 17:35:54 +0300 Received: from dev-l-vrt-207-011.mtl.labs.mlnx. (dev-l-vrt-207-011.mtl.labs.mlnx [10.134.207.11]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x92EZsEc000653; Wed, 2 Oct 2019 17:35:54 +0300 From: Tariq Toukan To: Stephen Hemminger , David Ahern Cc: netdev@vger.kernel.org, Moshe Shemesh , Aya Levin , Jiri Pirko , Tariq Toukan Subject: [PATCH V2 iproute2 3/3] devlink: Fix inconsistency between command input and output Date: Wed, 2 Oct 2019 17:35:16 +0300 Message-Id: <1570026916-27592-4-git-send-email-tariqt@mellanox.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1570026916-27592-1-git-send-email-tariqt@mellanox.com> References: <1570026916-27592-1-git-send-email-tariqt@mellanox.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Aya Levin In devlink health show command the reporter's name parameter is called reporter, but in the output the reporter's name is referred to as name Before this patch: $ devlink health show pci/0000:04:00.0 reporter tx pci/0000:04:00.0: name tx state healthy error 0 recover 0 grace_period 500 auto_recover true After this patch: $ devlink health show pci/0000:04:00.0 reporter tx pci/0000:04:00.0: reporter tx state healthy error 0 recover 0 grace_period 500 auto_recover true Reported-by: Jiri Pirko Fixes: 2f1242efe9d0 ("devlink: Add devlink health show command") Signed-off-by: Aya Levin Acked-by: Jiri Pirko Signed-off-by: Tariq Toukan --- devlink/devlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devlink/devlink.c b/devlink/devlink.c index 50baf82af937..5bbe0bddd910 100644 --- a/devlink/devlink.c +++ b/devlink/devlink.c @@ -6660,7 +6660,7 @@ static void pr_out_health(struct dl *dl, struct nlattr **tb_health) pr_out_handle_start_arr(dl, tb_health); - pr_out_str(dl, "name", + pr_out_str(dl, "reporter", mnl_attr_get_str(tb[DEVLINK_ATTR_HEALTH_REPORTER_NAME])); if (!dl->json_output) { __pr_out_newline();