| Message ID | 1563534631-15897-1-git-send-email-yash.shah@sifive.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | [1/3] macb: bindings doc: update sifive fu540-c000 binding | expand |
On 19/07/2019 at 13:10, Yash Shah wrote: > As per the discussion with Nicolas Ferre, rename the compatible property > to a more appropriate and specific string. > LINK: https://lkml.org/lkml/2019/7/17/200 > > Signed-off-by: Yash Shah <yash.shah@sifive.com> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> > --- > Documentation/devicetree/bindings/net/macb.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt > index 63c73fa..0b61a90 100644 > --- a/Documentation/devicetree/bindings/net/macb.txt > +++ b/Documentation/devicetree/bindings/net/macb.txt > @@ -15,10 +15,10 @@ Required properties: > Use "atmel,sama5d4-gem" for the GEM IP (10/100) available on Atmel sama5d4 SoCs. > Use "cdns,zynq-gem" Xilinx Zynq-7xxx SoC. > Use "cdns,zynqmp-gem" for Zynq Ultrascale+ MPSoC. > - Use "sifive,fu540-macb" for SiFive FU540-C000 SoC. > + Use "sifive,fu540-c000-gem" for SiFive FU540-C000 SoC. > Or the generic form: "cdns,emac". > - reg: Address and length of the register set for the device > - For "sifive,fu540-macb", second range is required to specify the > + For "sifive,fu540-c000-gem", second range is required to specify the > address and length of the registers for GEMGXL Management block. > - interrupts: Should contain macb interrupt > - phy-mode: See ethernet.txt file in the same directory. >
On Fri, 19 Jul 2019, Yash Shah wrote: > As per the discussion with Nicolas Ferre, rename the compatible property > to a more appropriate and specific string. > LINK: https://lkml.org/lkml/2019/7/17/200 > > Signed-off-by: Yash Shah <yash.shah@sifive.com> Reviewed-by: Paul Walmsley <paul.walmsley@sifive.com> - Paul
On Fri, 19 Jul 2019 16:40:29 +0530, Yash Shah wrote: > As per the discussion with Nicolas Ferre, rename the compatible property > to a more appropriate and specific string. > LINK: https://lkml.org/lkml/2019/7/17/200 > > Signed-off-by: Yash Shah <yash.shah@sifive.com> > --- > Documentation/devicetree/bindings/net/macb.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
Nicolas, Dave, On Mon, 12 Aug 2019, Rob Herring wrote: > On Fri, 19 Jul 2019 16:40:29 +0530, Yash Shah wrote: > > As per the discussion with Nicolas Ferre, rename the compatible property > > to a more appropriate and specific string. > > LINK: https://lkml.org/lkml/2019/7/17/200 > > > > Signed-off-by: Yash Shah <yash.shah@sifive.com> > > --- > > Documentation/devicetree/bindings/net/macb.txt | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > Reviewed-by: Rob Herring <robh@kernel.org> Am assuming you'll pick this up for the -net tree for v5.4-rc1 or earlier. If not, please let us know. - Paul
diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt index 63c73fa..0b61a90 100644 --- a/Documentation/devicetree/bindings/net/macb.txt +++ b/Documentation/devicetree/bindings/net/macb.txt @@ -15,10 +15,10 @@ Required properties: Use "atmel,sama5d4-gem" for the GEM IP (10/100) available on Atmel sama5d4 SoCs. Use "cdns,zynq-gem" Xilinx Zynq-7xxx SoC. Use "cdns,zynqmp-gem" for Zynq Ultrascale+ MPSoC. - Use "sifive,fu540-macb" for SiFive FU540-C000 SoC. + Use "sifive,fu540-c000-gem" for SiFive FU540-C000 SoC. Or the generic form: "cdns,emac". - reg: Address and length of the register set for the device - For "sifive,fu540-macb", second range is required to specify the + For "sifive,fu540-c000-gem", second range is required to specify the address and length of the registers for GEMGXL Management block. - interrupts: Should contain macb interrupt - phy-mode: See ethernet.txt file in the same directory.
As per the discussion with Nicolas Ferre, rename the compatible property to a more appropriate and specific string. LINK: https://lkml.org/lkml/2019/7/17/200 Signed-off-by: Yash Shah <yash.shah@sifive.com> --- Documentation/devicetree/bindings/net/macb.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)