| Message ID | 1562500388-16847-3-git-send-email-tariqt@mellanox.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | mlx5e devlink health reporters | expand |
Sun, Jul 07, 2019 at 01:52:54PM CEST, tariqt@mellanox.com wrote: >From: Aya Levin <ayal@mellanox.com> > >Fix tx reporter's diagnose call back. Propagate error when failing to s/call back/callback/ - it's a noun. >gather diagnostics information or failing to print diagnostic data per >queue. > >Signed-off-by: Aya Levin <ayal@mellanox.com> >Signed-off-by: Tariq Toukan <tariqt@mellanox.com> It's a fix, please provide "Fixes" line: Fixes: de8650a82071 ("net/mlx5e: Add tx reporter support") Also, it should be most likely sent to -net tree. The patch itself looks fine. Acked-by: Jiri Pirko <jiri@mellanox.com>
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c b/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c index 24626bb55598..b2bc8d8ca80e 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c @@ -264,13 +264,13 @@ static int mlx5e_tx_reporter_diagnose(struct devlink_health_reporter *reporter, err = mlx5_core_query_sq_state(priv->mdev, sq->sqn, &state); if (err) - break; + goto unlock; err = mlx5e_tx_reporter_build_diagnose_output(fmsg, sq->sqn, state, netif_xmit_stopped(sq->txq)); if (err) - break; + goto unlock; } err = devlink_fmsg_arr_pair_nest_end(fmsg); if (err)