diff mbox series

[net] net/mlx4_core: Change the error print to info print

Message ID 1557831799-15220-1-git-send-email-wangyunjian@huawei.com
State Accepted
Delegated to: David Miller
Headers show
Series [net] net/mlx4_core: Change the error print to info print | expand

Commit Message

wangyunjian May 14, 2019, 11:03 a.m. UTC
From: Yunjian Wang <wangyunjian@huawei.com>

The error print within mlx4_flow_steer_promisc_add() should
be a info print.

Fixes: 592e49dda812 ('net/mlx4: Implement promiscuous mode with device managed flow-steering')
Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
 drivers/net/ethernet/mellanox/mlx4/mcg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tariq Toukan May 14, 2019, 11:28 a.m. UTC | #1
On 5/14/2019 2:03 PM, wangyunjian wrote:
> From: Yunjian Wang <wangyunjian@huawei.com>
> 
> The error print within mlx4_flow_steer_promisc_add() should
> be a info print.
> 
> Fixes: 592e49dda812 ('net/mlx4: Implement promiscuous mode with device managed flow-steering')
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---
>   drivers/net/ethernet/mellanox/mlx4/mcg.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx4/mcg.c b/drivers/net/ethernet/mellanox/mlx4/mcg.c
> index ffed2d4..9c48182 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/mcg.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/mcg.c
> @@ -1492,7 +1492,7 @@ int mlx4_flow_steer_promisc_add(struct mlx4_dev *dev, u8 port,
>   	rule.port = port;
>   	rule.qpn = qpn;
>   	INIT_LIST_HEAD(&rule.list);
> -	mlx4_err(dev, "going promisc on %x\n", port);
> +	mlx4_info(dev, "going promisc on %x\n", port);
>   
>   	return  mlx4_flow_attach(dev, &rule, regid_p);
>   }
> 

LGTM.
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>

Thanks,
Tariq
David Miller May 14, 2019, 10:39 p.m. UTC | #2
From: wangyunjian <wangyunjian@huawei.com>
Date: Tue, 14 May 2019 19:03:19 +0800

> From: Yunjian Wang <wangyunjian@huawei.com>
> 
> The error print within mlx4_flow_steer_promisc_add() should
> be a info print.
> 
> Fixes: 592e49dda812 ('net/mlx4: Implement promiscuous mode with device managed flow-steering')
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/mellanox/mlx4/mcg.c b/drivers/net/ethernet/mellanox/mlx4/mcg.c
index ffed2d4..9c48182 100644
--- a/drivers/net/ethernet/mellanox/mlx4/mcg.c
+++ b/drivers/net/ethernet/mellanox/mlx4/mcg.c
@@ -1492,7 +1492,7 @@  int mlx4_flow_steer_promisc_add(struct mlx4_dev *dev, u8 port,
 	rule.port = port;
 	rule.qpn = qpn;
 	INIT_LIST_HEAD(&rule.list);
-	mlx4_err(dev, "going promisc on %x\n", port);
+	mlx4_info(dev, "going promisc on %x\n", port);
 
 	return  mlx4_flow_attach(dev, &rule, regid_p);
 }