| Message ID | 1557752799-9989-1-git-send-email-clabbe@baylibre.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: ethernet: stmmac: dwmac-sun8i: enable support of unicast filtering | expand |
Hello! On 05/13/2019 04:06 PM, Corentin Labbe wrote: > When adding more MAC address to a dwmac-sun8i interface, the device goes Addresses? > directly in promiscuous mode. > This is due to IFF_UNICAST_FLT missing flag. > > So since the hardware support unicast filtering, let's add IFF_UNICAST_FLT. > > Fixes: 9f93ac8d4085 ("net-next: stmmac: Add dwmac-sun8i") > Signed-off-by: Corentin Labbe <clabbe@baylibre.com> [...] MBR, Sergei
From: Corentin Labbe <clabbe@baylibre.com> Date: Mon, 13 May 2019 13:06:39 +0000 > When adding more MAC address to a dwmac-sun8i interface, the device goes > directly in promiscuous mode. > This is due to IFF_UNICAST_FLT missing flag. > > So since the hardware support unicast filtering, let's add IFF_UNICAST_FLT. > > Fixes: 9f93ac8d4085 ("net-next: stmmac: Add dwmac-sun8i") > Signed-off-by: Corentin Labbe <clabbe@baylibre.com> Applied with s/address/addresses/ Thanks.
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c index ac19bf62db70..9d3112beb19f 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c @@ -1018,6 +1018,8 @@ static struct mac_device_info *sun8i_dwmac_setup(void *ppriv) mac->mac = &sun8i_dwmac_ops; mac->dma = &sun8i_dwmac_dma_ops; + priv->dev->priv_flags |= IFF_UNICAST_FLT; + /* The loopback bit seems to be re-set when link change * Simply mask it each time * Speed 10/100/1000 are set in BIT(2)/BIT(3)
When adding more MAC address to a dwmac-sun8i interface, the device goes directly in promiscuous mode. This is due to IFF_UNICAST_FLT missing flag. So since the hardware support unicast filtering, let's add IFF_UNICAST_FLT. Fixes: 9f93ac8d4085 ("net-next: stmmac: Add dwmac-sun8i") Signed-off-by: Corentin Labbe <clabbe@baylibre.com> --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 2 ++ 1 file changed, 2 insertions(+)