| Message ID | 1555423463-6102-1-git-send-email-john.hurley@netronome.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next,1/1] nfp: flower: fix implicit fallthrough warning | expand |
From: John Hurley <john.hurley@netronome.com> Date: Tue, 16 Apr 2019 15:04:23 +0100 > The nfp_flower_copy_pre_actions function introduces a case statement with > an intentional fallthrough. However, this generates a warning if built > with the -Wimplicit-fallthrough flag. > > Remove the warning by adding a fall through comment. > > Fixes: 1c6952ca587d ("nfp: flower: generate merge flow rule") > Signed-off-by: John Hurley <john.hurley@netronome.com> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Reviewed-by: Jiong Wang <jiong.wang@netronome.com> > Reviewed-by: Simon Horman <simon.horman@netronome.com> Applied.
diff --git a/drivers/net/ethernet/netronome/nfp/flower/offload.c b/drivers/net/ethernet/netronome/nfp/flower/offload.c index df81d86..aefe211 100644 --- a/drivers/net/ethernet/netronome/nfp/flower/offload.c +++ b/drivers/net/ethernet/netronome/nfp/flower/offload.c @@ -629,6 +629,7 @@ nfp_flower_copy_pre_actions(char *act_dst, char *act_src, int len, case NFP_FL_ACTION_OPCODE_PRE_TUNNEL: if (tunnel_act) *tunnel_act = true; + /* fall through */ case NFP_FL_ACTION_OPCODE_PRE_LAG: memcpy(act_dst + act_off, act_src + act_off, act_len); break;
The nfp_flower_copy_pre_actions function introduces a case statement with an intentional fallthrough. However, this generates a warning if built with the -Wimplicit-fallthrough flag. Remove the warning by adding a fall through comment. Fixes: 1c6952ca587d ("nfp: flower: generate merge flow rule") Signed-off-by: John Hurley <john.hurley@netronome.com> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Reviewed-by: Jiong Wang <jiong.wang@netronome.com> Reviewed-by: Simon Horman <simon.horman@netronome.com> --- drivers/net/ethernet/netronome/nfp/flower/offload.c | 1 + 1 file changed, 1 insertion(+)