From patchwork Mon Feb 25 15:06:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Wei X-Patchwork-Id: 1047759 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=163.com header.i=@163.com header.b="nxP6gSuY"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 447QJW41QRz9s4Z for ; Tue, 26 Feb 2019 02:06:35 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727585AbfBYPGe (ORCPT ); Mon, 25 Feb 2019 10:06:34 -0500 Received: from m12-12.163.com ([220.181.12.12]:42830 "EHLO m12-12.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726675AbfBYPGe (ORCPT ); Mon, 25 Feb 2019 10:06:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=KIAIxHvvqkrt+IuNpg Qw8rltkQLH4Vv9m81BqtrUtas=; b=nxP6gSuYvNqQ/voTyedSQ5Ldqd/8R7bALf s1LY92qtG7K8oRfFqS/QG6HqCLNvS5uUJ+9Tg6F2WG2xS4lgjE4t2EBpLOBwhBk9 S+OJriFyrm6AODKhTaxBdf09CrOt90S80X2Y6bQx2U8iOL2kZ7xC7Sq+KX8gtyLo Rqt8aCjs4= Received: from yangwei-T440.lan (unknown [171.223.98.171]) by smtp8 (Coremail) with SMTP id DMCowABH+sxxBHRcpIkjHQ--.25529S3; Mon, 25 Feb 2019 23:06:26 +0800 (CST) From: Yang Wei To: netdev@vger.kernel.org Cc: davem@davemloft.net, yang.wei9@zte.com.cn, albin_yang@163.com Subject: [PATCH net-next] net: wan: z85230: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Date: Mon, 25 Feb 2019 23:06:24 +0800 Message-Id: <1551107184-16755-1-git-send-email-albin_yang@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: DMCowABH+sxxBHRcpIkjHQ--.25529S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrtrWDKF1xGrWrCw48Cr1DAwb_yoW3XFb_K3 4xZa17Jr4UZr1akr4F9a1SvFySyr15Zr409rySqrWSq34qvr9rA3sYvFnrGryagw45GFy7 KryDZF4UZr4akjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU8uT5DUUUUU== X-Originating-IP: [171.223.98.171] X-CM-SenderInfo: pdoex0xb1d0wi6rwjhhfrp/1tbiLwhmolUMK0NU3AABsb Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yang Wei dev_consume_skb_irq() should be called in z8530_tx_done() when skb xmit done. It makes drop profiles(dropwatch, perf) more friendly. Signed-off-by: Yang Wei --- drivers/net/wan/z85230.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wan/z85230.c b/drivers/net/wan/z85230.c index deea41e..0e56ab0 100644 --- a/drivers/net/wan/z85230.c +++ b/drivers/net/wan/z85230.c @@ -1536,7 +1536,7 @@ static void z8530_tx_done(struct z8530_channel *c) z8530_tx_begin(c); c->netdevice->stats.tx_packets++; c->netdevice->stats.tx_bytes += skb->len; - dev_kfree_skb_irq(skb); + dev_consume_skb_irq(skb); } /**