From patchwork Wed Feb 13 15:15:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Wei X-Patchwork-Id: 1041339 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=163.com header.i=@163.com header.b="XSuR7cCN"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44034x6gckz9s7h for ; Thu, 14 Feb 2019 02:16:01 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390062AbfBMPP7 (ORCPT ); Wed, 13 Feb 2019 10:15:59 -0500 Received: from m12-17.163.com ([220.181.12.17]:44332 "EHLO m12-17.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732927AbfBMPP7 (ORCPT ); Wed, 13 Feb 2019 10:15:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=CS+firVCteznGgmCHm NU6EaXiAODeOX/qdzFJ35AJRE=; b=XSuR7cCNBbF8zKKub6Z9MWWP0e2J6tPeFy y/CIww2E75yaRslKA24Zup859t1+e/GWUP1OtfKQxRGQj0EHzjdFevDoU96mDon7 lTCIgg9U8xuU20jZsELHcUCG+b91X506FSZZ7sEqvVU15BLAB67A+l0daiuDSp6s 7phdkgkIE= Received: from yangwei-T440.lan (unknown [125.69.43.124]) by smtp13 (Coremail) with SMTP id EcCowACX5LSjNGRcr11jFg--.33588S3; Wed, 13 Feb 2019 23:15:48 +0800 (CST) From: Yang Wei To: netdev@vger.kernel.org Cc: christopher.lee@cspi.com, davem@davemloft.net, yang.wei9@zte.com.cn, albin_yang@163.com Subject: [PATCH net] net: myri10ge: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Date: Wed, 13 Feb 2019 23:15:43 +0800 Message-Id: <1550070943-4653-1-git-send-email-albin_yang@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: EcCowACX5LSjNGRcr11jFg--.33588S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrtrWDKF47Ar4UuryUuF1fCrg_yoWftFg_CF n0qF1fXa1UGrW5tr4YkF45AryS9wn8Xw4rZryxtFWft3yqq3W3Jw1DGrZxurWvgw4UJFy7 Ary2qrZ8uwn0gjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUjsqXtUUUUU== X-Originating-IP: [125.69.43.124] X-CM-SenderInfo: pdoex0xb1d0wi6rwjhhfrp/1tbiqwRaolUMOFRVgAAAs3 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yang Wei dev_consume_skb_irq() should be called in myri10ge_tx_done() when skb xmit done. It makes drop profiles(dropwatch, perf) more friendly. Signed-off-by: Yang Wei --- drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c index 19ce0e6..e0340f7 100644 --- a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c +++ b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c @@ -1408,7 +1408,7 @@ myri10ge_tx_done(struct myri10ge_slice_state *ss, int mcp_index) if (skb) { ss->stats.tx_bytes += skb->len; ss->stats.tx_packets++; - dev_kfree_skb_irq(skb); + dev_consume_skb_irq(skb); if (len) pci_unmap_single(pdev, dma_unmap_addr(&tx->info[idx],