| Message ID | 1550055743-15542-3-git-send-email-claudiu.manoil@nxp.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | enetc: Add mdio support and device tree nodes | expand |
On Wed, Feb 13, 2019 at 01:02:22PM +0200, Claudiu Manoil wrote: > The LS1028A RDB board features an Atheros PHY connected over > SGMII to the ENETC PF0 (or Port0). ENETC Port1 (PF1) has no > external connection on this board, so it can be disabled for now. > > Signed-off-by: Alex Marginean <alexandru.marginean@nxp.com> > Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com> > --- > arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts > index fdeb417..c8487893 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts > @@ -71,3 +71,18 @@ > &duart1 { > status = "okay"; > }; > + > +&enetc_port0 { > + phy-handle = <&sgmii_phy0>; > + phy-connection-type = "sgmii"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + sgmii_phy0: ethernet-phy@2 { > + reg = <0x2>; > + }; > +}; > + Hi Claudiu It is better to use: &enetc_port0 { phy-handle = <&sgmii_phy0>; phy-connection-type = "sgmii"; #address-cells = <1>; #size-cells = <0>; mdio { sgmii_phy0: ethernet-phy@2 { reg = <0x2>; }; }; }; Andrew
>-----Original Message----- >From: Andrew Lunn <andrew@lunn.ch> >Sent: Wednesday, February 13, 2019 8:16 PM >To: Claudiu Manoil <claudiu.manoil@nxp.com> >Cc: Shawn Guo <shawnguo@kernel.org>; Leo Li <leoyang.li@nxp.com>; David S . >Miller <davem@davemloft.net>; devicetree@vger.kernel.org; Alexandru >Marginean <alexandru.marginean@nxp.com>; linux-kernel@vger.kernel.org; >linux-arm-kernel@lists.infradead.org; netdev@vger.kernel.org >Subject: Re: [PATCH net-next 2/3] arm64: dts: fsl: ls1028a-rdb: Add ENETC >external eth ports for the LS1028A RDB board > >On Wed, Feb 13, 2019 at 01:02:22PM +0200, Claudiu Manoil wrote: >> The LS1028A RDB board features an Atheros PHY connected over SGMII to >> the ENETC PF0 (or Port0). ENETC Port1 (PF1) has no external >> connection on this board, so it can be disabled for now. >> >> Signed-off-by: Alex Marginean <alexandru.marginean@nxp.com> >> Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com> >> --- >> arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts | 15 >> +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts >> b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts >> index fdeb417..c8487893 100644 >> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts >> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts >> @@ -71,3 +71,18 @@ >> &duart1 { >> status = "okay"; >> }; >> + >> +&enetc_port0 { >> + phy-handle = <&sgmii_phy0>; >> + phy-connection-type = "sgmii"; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + sgmii_phy0: ethernet-phy@2 { >> + reg = <0x2>; >> + }; >> +}; >> + > >Hi Claudiu > >It is better to use: > >&enetc_port0 { > phy-handle = <&sgmii_phy0>; > phy-connection-type = "sgmii"; > #address-cells = <1>; > #size-cells = <0>; > > mdio { > sgmii_phy0: ethernet-phy@2 { > reg = <0x2>; > }; > }; >}; Hi Andrew, The extra node for mdio seems to complicate things somewhat. Just adding this node seems not enough. How to find out easily if a child of a enetc port node is a mdio node? I was thinking to use device_type for that, like this: &enetc_port0 { phy-handle = <&sgmii_phy0>; phy-connection-type = "sgmii"; mdio { #address-cells = <1>; #size-cells = <0>; device_type = "mdio"; sgmii_phy0: ethernet-phy@2 { reg = <0x2>; }; }; }; Would you agree with this? Thanks, Claudiu
> Hi Andrew, > > The extra node for mdio seems to complicate things somewhat. > Just adding this node seems not enough. How to find out easily if a child > of a enetc port node is a mdio node? You copy somebody else code :-) https://elixir.bootlin.com/linux/v5.0-rc6/source/drivers/net/dsa/mv88e6xxx/chip.c#L2765 Andrew
>-----Original Message----- >From: Andrew Lunn <andrew@lunn.ch> >Sent: Thursday, February 14, 2019 6:28 PM >To: Claudiu Manoil <claudiu.manoil@nxp.com> >Cc: Shawn Guo <shawnguo@kernel.org>; Leo Li <leoyang.li@nxp.com>; David S . >Miller <davem@davemloft.net>; devicetree@vger.kernel.org; Alexandru >Marginean <alexandru.marginean@nxp.com>; linux-kernel@vger.kernel.org; >linux-arm-kernel@lists.infradead.org; netdev@vger.kernel.org >Subject: Re: [PATCH net-next 2/3] arm64: dts: fsl: ls1028a-rdb: Add ENETC >external eth ports for the LS1028A RDB board > >> Hi Andrew, >> >> The extra node for mdio seems to complicate things somewhat. >> Just adding this node seems not enough. How to find out easily if a >> child of a enetc port node is a mdio node? > >You copy somebody else code :-) > Provided you find the right thing to copy : ) . Thanks for the hint.
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts index fdeb417..c8487893 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts @@ -71,3 +71,18 @@ &duart1 { status = "okay"; }; + +&enetc_port0 { + phy-handle = <&sgmii_phy0>; + phy-connection-type = "sgmii"; + #address-cells = <1>; + #size-cells = <0>; + + sgmii_phy0: ethernet-phy@2 { + reg = <0x2>; + }; +}; + +&enetc_port1 { + status = "disabled"; +};