From patchwork Mon Feb 11 11:09:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Li RongQing X-Patchwork-Id: 1039745 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=baidu.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43yjx348VHz9s5c for ; Mon, 11 Feb 2019 22:19:35 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726831AbfBKLTd (ORCPT ); Mon, 11 Feb 2019 06:19:33 -0500 Received: from mx139-tc.baidu.com ([61.135.168.139]:42614 "EHLO tc-sys-mailedm05.tc.baidu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726045AbfBKLTd (ORCPT ); Mon, 11 Feb 2019 06:19:33 -0500 X-Greylist: delayed 607 seconds by postgrey-1.27 at vger.kernel.org; Mon, 11 Feb 2019 06:19:32 EST Received: from localhost (cp01-cos-dev01.cp01.baidu.com [10.92.119.46]) by tc-sys-mailedm05.tc.baidu.com (Postfix) with ESMTP id EA99C1EBA003 for ; Mon, 11 Feb 2019 19:09:07 +0800 (CST) From: Li RongQing To: netdev@vger.kernel.org Subject: [PATCH][net-next] devlink: use direct return of genlmsg_reply Date: Mon, 11 Feb 2019 19:09:07 +0800 Message-Id: <1549883347-23907-1-git-send-email-lirongqing@baidu.com> X-Mailer: git-send-email 1.7.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This can remove redundant check Signed-off-by: Li RongQing --- net/core/devlink.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/net/core/devlink.c b/net/core/devlink.c index e6a015b8ac9b..76a9d287dbec 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -4355,11 +4355,8 @@ static int devlink_fmsg_snd(struct devlink_fmsg *fmsg, err = -EMSGSIZE; goto nla_put_failure; } - err = genlmsg_reply(skb, info); - if (err) - return err; - return 0; + return genlmsg_reply(skb, info); nla_put_failure: nlmsg_free(skb);