Message ID | 1549883347-23907-1-git-send-email-lirongqing@baidu.com |
---|---|
State | Accepted |
Delegated to: | David Miller |
Headers | show |
Series | [net-next] devlink: use direct return of genlmsg_reply | expand |
From: Li RongQing <lirongqing@baidu.com> Date: Mon, 11 Feb 2019 19:09:07 +0800 > This can remove redundant check > > Signed-off-by: Li RongQing <lirongqing@baidu.com> Applied.
diff --git a/net/core/devlink.c b/net/core/devlink.c index e6a015b8ac9b..76a9d287dbec 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -4355,11 +4355,8 @@ static int devlink_fmsg_snd(struct devlink_fmsg *fmsg, err = -EMSGSIZE; goto nla_put_failure; } - err = genlmsg_reply(skb, info); - if (err) - return err; - return 0; + return genlmsg_reply(skb, info); nla_put_failure: nlmsg_free(skb);
This can remove redundant check Signed-off-by: Li RongQing <lirongqing@baidu.com> --- net/core/devlink.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)