From patchwork Tue Feb 5 16:12:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Wei X-Patchwork-Id: 1036878 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=163.com header.i=@163.com header.b="StewY9o5"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43v8jc3yXzz9sMx for ; Wed, 6 Feb 2019 03:12:20 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728445AbfBEQMS (ORCPT ); Tue, 5 Feb 2019 11:12:18 -0500 Received: from m12-17.163.com ([220.181.12.17]:41296 "EHLO m12-17.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727352AbfBEQMS (ORCPT ); Tue, 5 Feb 2019 11:12:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=clq5iGwZ+KL5QlGoQC bSixrzg096eQvhYhfZ08z+uDo=; b=StewY9o5IiYdGOy7rNG7vRq3UY+soik7Xx 4r/EXZdFIvehht7Ld606sIiTHg9Pc5AuJsNK01TtmiMLVx1RjAiU+bQQw4zsXh9p Rrpo2bHagRdh/+iA3hTZhkP0sdHA8Oze/xLwuEP/95LoNO/mtxcK9X0cjb6X32DB P+yDw0B6s= Received: from localhost.localdomain (unknown [171.210.152.198]) by smtp13 (Coremail) with SMTP id EcCowACng8DatVlcPuTzEQ--.54510S3; Wed, 06 Feb 2019 00:12:12 +0800 (CST) From: Yang Wei To: netdev@vger.kernel.org Cc: davem@davemloft.net, yang.wei9@zte.com.cn, albin_yang@163.com Subject: [PATCH net] net: fec_mpc52xx: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Date: Wed, 6 Feb 2019 00:12:04 +0800 Message-Id: <1549383124-5443-1-git-send-email-albin_yang@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: EcCowACng8DatVlcPuTzEQ--.54510S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrtrWDKF1DCry3Zr4xKr4DJwb_yoWfAwbEgr 12vr1xJw4UJF13tw1Fkw4rZryF9ry5XrW8Zas7tFW5G3srurn8Jr4kXrn3GF1fKr45CFZr C3yagrW5Z34YyjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU8Ha0DUUUUU== X-Originating-IP: [171.210.152.198] X-CM-SenderInfo: pdoex0xb1d0wi6rwjhhfrp/xtbBERxSolaD2dKHogAAsG Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yang Wei dev_consume_skb_irq() should be called in mpc52xx_fec_tx_interrupt() when skb xmit done. It makes drop profiles(dropwatch, perf) more friendly. Signed-off-by: Yang Wei --- drivers/net/ethernet/freescale/fec_mpc52xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fec_mpc52xx.c b/drivers/net/ethernet/freescale/fec_mpc52xx.c index b90bab7..c1968b3 100644 --- a/drivers/net/ethernet/freescale/fec_mpc52xx.c +++ b/drivers/net/ethernet/freescale/fec_mpc52xx.c @@ -369,7 +369,7 @@ static irqreturn_t mpc52xx_fec_tx_interrupt(int irq, void *dev_id) dma_unmap_single(dev->dev.parent, bd->skb_pa, skb->len, DMA_TO_DEVICE); - dev_kfree_skb_irq(skb); + dev_consume_skb_irq(skb); } spin_unlock(&priv->lock);