From patchwork Mon Feb 4 17:00:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ioana Radulescu X-Patchwork-Id: 1036075 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="KNmHuB7K"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43tYr25pjhz9s3l for ; Tue, 5 Feb 2019 04:00:50 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730378AbfBDRAu (ORCPT ); Mon, 4 Feb 2019 12:00:50 -0500 Received: from mail-eopbgr140047.outbound.protection.outlook.com ([40.107.14.47]:26877 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728479AbfBDRAt (ORCPT ); Mon, 4 Feb 2019 12:00:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vcpmsHaV2isJ7q7L+a/qWwwCkSD8r6m1Sd8Hj9k0wTI=; b=KNmHuB7KERrDZ7Gwcx6XfcCuArVVwD5MGpO7yLppqihZzSdewNF0BYW/DcYsWZ6PKj33Sp5svcuVDFSTcl1YZzIImw4QyHvo7glCqUJdLydEFmDF34cJeYjVGIyOvRdYUg89+A+13D8PDBJ66gALp8VMR4aTdOwpg2u3c7IFcfw= Received: from AM0PR04MB4994.eurprd04.prod.outlook.com (20.177.40.15) by AM0PR04MB4900.eurprd04.prod.outlook.com (20.176.215.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1580.20; Mon, 4 Feb 2019 17:00:36 +0000 Received: from AM0PR04MB4994.eurprd04.prod.outlook.com ([fe80::4dc:92fb:eaf8:d6fa]) by AM0PR04MB4994.eurprd04.prod.outlook.com ([fe80::4dc:92fb:eaf8:d6fa%3]) with mapi id 15.20.1580.019; Mon, 4 Feb 2019 17:00:36 +0000 From: Ioana Ciocoi Radulescu To: "netdev@vger.kernel.org" , "davem@davemloft.net" CC: Ioana Ciornei , "brouer@redhat.com" , "ilias.apalodimas@linaro.org" Subject: [PATCH net-next 2/4] dpaa2-eth: Use napi_consume_skb() Thread-Topic: [PATCH net-next 2/4] dpaa2-eth: Use napi_consume_skb() Thread-Index: AQHUvKslDGRwjnllm0mQsVIsEj8dgg== Date: Mon, 4 Feb 2019 17:00:35 +0000 Message-ID: <1549299625-28399-3-git-send-email-ruxandra.radulescu@nxp.com> References: <1549299625-28399-1-git-send-email-ruxandra.radulescu@nxp.com> In-Reply-To: <1549299625-28399-1-git-send-email-ruxandra.radulescu@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: VI1PR0701CA0060.eurprd07.prod.outlook.com (2603:10a6:800:5f::22) To AM0PR04MB4994.eurprd04.prod.outlook.com (2603:10a6:208:c7::15) authentication-results: spf=none (sender IP is ) smtp.mailfrom=ruxandra.radulescu@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.7.4 x-originating-ip: [86.34.165.90] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM0PR04MB4900; 6:Pozmq5HGt8ySTgcRSxHYI3oiwbGoNtlXQ5rsYUYs/a7rqciBWu6GdTyQk5wCwHAPl7Qnzdi23BQGdwpPdyfUqHdT9zMktXeIPIBwJFJ6QBU8ciKVS72QCccZeC4ov/78BoOSDoIj9MnfLSVZUZKJTKBMniT5ra7fUWzMOx0dCbNUJNe1X4R8YN71TF4iiYexovlQ7MgZoz+/PekaW5JL8VPgEJp5+KvexksACCG4gFySeRwuyfeDYk2DmKVjRicyC9oQ+43jhgUXvRgv7ApS9Rm1UNrLF0RbsUrIni48l7lIvGwNMGFZsXRXHob+kn0S3TEBBxb9rfxu5x9TiAYEKG3AbtifLUic7NJe7RmBq78VST1Zd3syI0S9JalE2pP151iV0HyT4K3AhlSKWiI9PEVZVAjSzNtlnxayAjHlUZpc+c+823869q5pbv8+IlDXu445bzXNBQMdnknqpyVV0Q==; 5:j/gyMVc3/WShpOVuEVuNN1pgmtDbzPAzd/t8fzU8I7P6Yv423EWTMMRynanlsyXyeMZB2PkNhFtnCBFd7FKWiw/C0OPySNsz12EhylZ/7/LGo9C3nTQ9QwPQ8BHt/N/Lgf8WFKc255u0FmenOnWuWLHknxatLy6pRP+yCjAza23LDjMYZkkC3Rfk+UXUnL04q9Qhq3cKfvJpsxSfj+eZlQ==; 7:ZKkOWAs0crrxahV0zuc4aWW76gdLta4Hss1YQ20LwpG9/nraqCiCY8elEy7IHjreTLYREsxQR8pMQNP1z8hag3WzVxhuDgPqKLAyeAwHx0UqUZrxTwqs1gfI5u9mW0rpnWPToeptzn0O0wZSkBfsSQ== x-ms-office365-filtering-correlation-id: 08cda51d-dff2-4cef-80ba-08d68ac2480c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM0PR04MB4900; x-ms-traffictypediagnostic: AM0PR04MB4900: x-microsoft-antispam-prvs: x-forefront-prvs: 0938781D02 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(396003)(376002)(136003)(366004)(39860400002)(199004)(189003)(478600001)(476003)(2906002)(102836004)(7736002)(11346002)(446003)(25786009)(66066001)(14454004)(97736004)(71200400001)(486006)(26005)(76176011)(81156014)(81166006)(2616005)(2501003)(71190400001)(8676002)(50226002)(36756003)(86362001)(8936002)(106356001)(99286004)(52116002)(316002)(53936002)(110136005)(105586002)(6486002)(68736007)(4326008)(54906003)(6436002)(256004)(6116002)(3846002)(305945005)(186003)(6506007)(6512007)(386003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR04MB4900; H:AM0PR04MB4994.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: kPl0HASwyr6PJs2BiMZrK2ktn87bUwONE/tHcgTZKxv3MyTPegEmSqy5+VhF6nnfqf8vkWPVb4oOCF5oobXhDiCeGCL01F1JE0MaeYNZJ0gKQDrVymt7Ldl8QShdPIeunfFIoNkt4l/iP9edxfAQ5kgPHIMNESBPuUI71VoMbasJTP0yxf+fKRUnySGRzD9EO13fN+RLfkeomaxnBFrpkckxTLn+KAVPHNPJt6By+TOOXNtmibEYC7Hw85SRQ52ifn4TJYTgDBT+LVty5Cya+DoXJflUS1+bEdpetpblVqPpdsSWuDfSShIjO/93nmH5g3S4ZwM/H7sODq+G0JxoZOGOL77rn/B7E4J3w2cDraL9nrxm6cPGyiQHq9y0k1ieSezOAZ4YTjkUm5Z3wKtAcFYA8AzoG+VeD5vMSKjLDdA= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08cda51d-dff2-4cef-80ba-08d68ac2480c X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2019 17:00:35.2998 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4900 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org While in NAPI context, free skbs by calling napi_consume_skb() instead of dev_kfree_skb(), to take advantage of the bulk freeing mechanism. Signed-off-by: Ioana Radulescu --- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c index 6e58de6..3bc5437 100644 --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c @@ -657,7 +657,7 @@ static int build_single_fd(struct dpaa2_eth_priv *priv, * dpaa2_eth_tx(). */ static void free_tx_fd(const struct dpaa2_eth_priv *priv, - const struct dpaa2_fd *fd) + const struct dpaa2_fd *fd, bool in_napi) { struct device *dev = priv->net_dev->dev.parent; dma_addr_t fd_addr; @@ -712,7 +712,7 @@ static void free_tx_fd(const struct dpaa2_eth_priv *priv, skb_free_frag(skbh); /* Move on with skb release */ - dev_kfree_skb(skb); + napi_consume_skb(skb, in_napi); } static netdev_tx_t dpaa2_eth_tx(struct sk_buff *skb, struct net_device *net_dev) @@ -795,7 +795,7 @@ static netdev_tx_t dpaa2_eth_tx(struct sk_buff *skb, struct net_device *net_dev) if (unlikely(err < 0)) { percpu_stats->tx_errors++; /* Clean up everything, including freeing the skb */ - free_tx_fd(priv, &fd); + free_tx_fd(priv, &fd, false); } else { fd_len = dpaa2_fd_get_len(&fd); percpu_stats->tx_packets++; @@ -837,7 +837,7 @@ static void dpaa2_eth_tx_conf(struct dpaa2_eth_priv *priv, /* Check frame errors in the FD field */ fd_errors = dpaa2_fd_get_ctrl(fd) & DPAA2_FD_TX_ERR_MASK; - free_tx_fd(priv, fd); + free_tx_fd(priv, fd, true); if (likely(!fd_errors)) return;