diff mbox series

[net] net: caif: call dev_consume_skb_any when skb xmit done

Message ID 1548775942-6476-1-git-send-email-albin_yang@163.com
State Accepted
Delegated to: David Miller
Headers show
Series [net] net: caif: call dev_consume_skb_any when skb xmit done | expand

Commit Message

Yang Wei Jan. 29, 2019, 3:32 p.m. UTC 
From: Yang Wei <yang.wei9@zte.com.cn>

The skb shouled be consumed when xmit done, it makes drop profiles
(dropwatch, perf) more friendly.
dev_kfree_skb_irq()/kfree_skb() shouled be replaced by 
dev_consume_skb_any(), it makes code cleaner.

Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>
---
 drivers/net/caif/caif_serial.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

David Miller Jan. 29, 2019, 6:11 p.m. UTC | #1 
From: Yang Wei <albin_yang@163.com>
Date: Tue, 29 Jan 2019 23:32:22 +0800

> From: Yang Wei <yang.wei9@zte.com.cn>
> 
> The skb shouled be consumed when xmit done, it makes drop profiles
> (dropwatch, perf) more friendly.
> dev_kfree_skb_irq()/kfree_skb() shouled be replaced by 
> dev_consume_skb_any(), it makes code cleaner.
> 
> Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>

Applied.
diff mbox series

Patch

diff --git a/drivers/net/caif/caif_serial.c b/drivers/net/caif/caif_serial.c
index a0f954f..44e6c7b 100644
--- a/drivers/net/caif/caif_serial.c
+++ b/drivers/net/caif/caif_serial.c
@@ -257,10 +257,7 @@  static int handle_tx(struct ser_device *ser)
 		if (skb->len == 0) {
 			struct sk_buff *tmp = skb_dequeue(&ser->head);
 			WARN_ON(tmp != skb);
-			if (in_interrupt())
-				dev_kfree_skb_irq(skb);
-			else
-				kfree_skb(skb);
+			dev_consume_skb_any(skb);
 		}
 	}
 	/* Send flow off if queue is empty */