diff mbox series

[net] net: b44: replace dev_kfree_skb_xxx by dev_consume_skb_xxx for drop profiles

Message ID 1548774280-5757-1-git-send-email-albin_yang@163.com
State Accepted
Delegated to: David Miller
Headers show
Series [net] net: b44: replace dev_kfree_skb_xxx by dev_consume_skb_xxx for drop profiles | expand

Commit Message

Yang Wei Jan. 29, 2019, 3:04 p.m. UTC 
From: Yang Wei <yang.wei9@zte.com.cn>

The skb should be freed by dev_consume_skb_any() in b44_start_xmit()
when bounce_skb is used. The skb is be replaced by bounce_skb, so the
original skb should be consumed(not drop).

dev_consume_skb_irq() should be called in b44_tx() when skb xmit 
done. It makes drop profiles(dropwatch, perf) more friendly.

Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>
---
 drivers/net/ethernet/broadcom/b44.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

David Miller Jan. 29, 2019, 6:11 p.m. UTC | #1 
From: Yang Wei <albin_yang@163.com>
Date: Tue, 29 Jan 2019 23:04:40 +0800

> From: Yang Wei <yang.wei9@zte.com.cn>
> 
> The skb should be freed by dev_consume_skb_any() in b44_start_xmit()
> when bounce_skb is used. The skb is be replaced by bounce_skb, so the
> original skb should be consumed(not drop).
> 
> dev_consume_skb_irq() should be called in b44_tx() when skb xmit 
> done. It makes drop profiles(dropwatch, perf) more friendly.
> 
> Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>

Applied.
Sergei Shtylyov Jan. 30, 2019, 7:43 a.m. UTC | #2 
Hello!

On 29.01.2019 18:04, Yang Wei wrote:

> From: Yang Wei <yang.wei9@zte.com.cn>
> 
> The skb should be freed by dev_consume_skb_any() in b44_start_xmit()
> when bounce_skb is used. The skb is be replaced by bounce_skb, so the

    s/be/being/?

> original skb should be consumed(not drop).
> 
> dev_consume_skb_irq() should be called in b44_tx() when skb xmit
> done. It makes drop profiles(dropwatch, perf) more friendly.
> 
> Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>
[...]

MBR, Sergei
diff mbox series

Patch

diff --git a/drivers/net/ethernet/broadcom/b44.c b/drivers/net/ethernet/broadcom/b44.c
index f448089..97ab0dd 100644
--- a/drivers/net/ethernet/broadcom/b44.c
+++ b/drivers/net/ethernet/broadcom/b44.c
@@ -638,7 +638,7 @@  static void b44_tx(struct b44 *bp)
 		bytes_compl += skb->len;
 		pkts_compl++;
 
-		dev_kfree_skb_irq(skb);
+		dev_consume_skb_irq(skb);
 	}
 
 	netdev_completed_queue(bp->dev, pkts_compl, bytes_compl);
@@ -1012,7 +1012,7 @@  static netdev_tx_t b44_start_xmit(struct sk_buff *skb, struct net_device *dev)
 		}
 
 		skb_copy_from_linear_data(skb, skb_put(bounce_skb, len), len);
-		dev_kfree_skb_any(skb);
+		dev_consume_skb_any(skb);
 		skb = bounce_skb;
 	}