| Message ID | 1548350221-8512-1-git-send-email-tlfalcon@linux.ibm.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net] ibmveth: Do not process frames after calling napi_reschedule | expand |
From: Thomas Falcon <tlfalcon@linux.ibm.com> Date: Thu, 24 Jan 2019 11:17:01 -0600 > The IBM virtual ethernet driver's polling function continues > to process frames after rescheduling NAPI, resulting in a warning > if it exhausted its budget. Do not restart polling after calling > napi_reschedule. Instead let frames be processed in the following > instance. > > Signed-off-by: Thomas Falcon <tlfalcon@linux.ibm.com> Applied.
diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c index 098d876..dd71d5d 100644 --- a/drivers/net/ethernet/ibm/ibmveth.c +++ b/drivers/net/ethernet/ibm/ibmveth.c @@ -1313,7 +1313,6 @@ static int ibmveth_poll(struct napi_struct *napi, int budget) unsigned long lpar_rc; u16 mss = 0; -restart_poll: while (frames_processed < budget) { if (!ibmveth_rxq_pending_buffer(adapter)) break; @@ -1401,7 +1400,6 @@ static int ibmveth_poll(struct napi_struct *napi, int budget) napi_reschedule(napi)) { lpar_rc = h_vio_signal(adapter->vdev->unit_address, VIO_IRQ_DISABLE); - goto restart_poll; } }
The IBM virtual ethernet driver's polling function continues to process frames after rescheduling NAPI, resulting in a warning if it exhausted its budget. Do not restart polling after calling napi_reschedule. Instead let frames be processed in the following instance. Signed-off-by: Thomas Falcon <tlfalcon@linux.ibm.com> --- drivers/net/ethernet/ibm/ibmveth.c | 2 -- 1 file changed, 2 deletions(-)