diff mbox series

[net-next] net: remove BUG_ON from __pskb_pull_tail

Message ID 1542014773-23361-1-git-send-email-lirongqing@baidu.com
State Changes Requested, archived
Delegated to: David Miller
Headers show
Series [net-next] net: remove BUG_ON from __pskb_pull_tail | expand

Commit Message

Li RongQing Nov. 12, 2018, 9:26 a.m. UTC
if list is NULL pointer, and the following access of list
will trigger panic, which is same as BUG_ON

Signed-off-by: Li RongQing <lirongqing@baidu.com>
---
 net/core/skbuff.c | 1 -
 1 file changed, 1 deletion(-)

Comments

David Miller Nov. 12, 2018, 4:55 p.m. UTC | #1
From: Li RongQing <lirongqing@baidu.com>
Date: Mon, 12 Nov 2018 17:26:13 +0800

>  		do {
> -			BUG_ON(!list);
>  

Please get rid of the empty line afterwards as well.

Thank you.
diff mbox series

Patch

diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 396fcb3baad0..cd668b52f96f 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -1925,7 +1925,6 @@  void *__pskb_pull_tail(struct sk_buff *skb, int delta)
 		struct sk_buff *insp = NULL;
 
 		do {
-			BUG_ON(!list);
 
 			if (list->len <= eat) {
 				/* Eaten as whole. */