From patchwork Wed Oct 3 00:52:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Subash Abhinov Kasiviswanathan X-Patchwork-Id: 978095 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=codeaurora.org header.i=@codeaurora.org header.b="SPUm/ty+"; dkim=pass (1024-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="SPUm/ty+"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42PyGM1d5Wz9sBJ for ; Wed, 3 Oct 2018 10:54:35 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726451AbeJCHj4 (ORCPT ); Wed, 3 Oct 2018 03:39:56 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:49770 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726120AbeJCHj4 (ORCPT ); Wed, 3 Oct 2018 03:39:56 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id B863F60C61; Wed, 3 Oct 2018 00:53:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1538528033; bh=leq+QayD4pW6wEySC90/jxNdsahvlCWKGi7gKdzVYyA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SPUm/ty+jCEgPyDrRmWTjeMO8M9l3Y7Oa+BDJDZqwyy3yWr5Q3NfafMlgiI1+03ZY uq3iotc3gMSCJ9pLXcunzc33/eLXil1FitwJ+i9BFsO9txmbFR1t8xI7SpRoCUh/6T sSxWBDu2bN0nMmkcUzm89fWoi4FVNgDaV0k9Zffs= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID, DKIM_SIGNED autolearn=no autolearn_force=no version=3.4.0 Received: from subashab-lnx.qualcomm.com (unknown [129.46.15.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: subashab@codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id E134060BF4; Wed, 3 Oct 2018 00:53:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1538528033; bh=leq+QayD4pW6wEySC90/jxNdsahvlCWKGi7gKdzVYyA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SPUm/ty+jCEgPyDrRmWTjeMO8M9l3Y7Oa+BDJDZqwyy3yWr5Q3NfafMlgiI1+03ZY uq3iotc3gMSCJ9pLXcunzc33/eLXil1FitwJ+i9BFsO9txmbFR1t8xI7SpRoCUh/6T sSxWBDu2bN0nMmkcUzm89fWoi4FVNgDaV0k9Zffs= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E134060BF4 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=subashab@codeaurora.org From: Subash Abhinov Kasiviswanathan To: davem@davemloft.net, netdev@vger.kernel.org Cc: Sean Tranchetti , Subash Abhinov Kasiviswanathan Subject: [PATCH net 1/3] net: qualcomm: rmnet: Skip processing loopback packets Date: Tue, 2 Oct 2018 18:52:01 -0600 Message-Id: <1538527923-29562-2-git-send-email-subashab@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1538527923-29562-1-git-send-email-subashab@codeaurora.org> References: <1538527923-29562-1-git-send-email-subashab@codeaurora.org> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Sean Tranchetti RMNET RX handler was processing invalid packets that were originally sent on the real device and were looped back via dev_loopback_xmit(). This was detected using syzkaller. Fixes: ceed73a2cf4a ("drivers: net: ethernet: qualcomm: rmnet: Initial implementation") Signed-off-by: Sean Tranchetti Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c b/drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c index 7fd86d4..6908b26 100644 --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c @@ -189,6 +189,9 @@ rx_handler_result_t rmnet_rx_handler(struct sk_buff **pskb) if (!skb) goto done; + if (skb->pkt_type == PACKET_LOOPBACK) + return RX_HANDLER_PASS; + dev = skb->dev; port = rmnet_get_port(dev);