From patchwork Thu Sep 20 01:56:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: zhong jiang X-Patchwork-Id: 972105 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=huawei.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42G0YV5S55z9sCP for ; Thu, 20 Sep 2018 12:10:06 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731694AbeITHun (ORCPT ); Thu, 20 Sep 2018 03:50:43 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:12215 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725914AbeITHum (ORCPT ); Thu, 20 Sep 2018 03:50:42 -0400 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 3641D244FBED3; Thu, 20 Sep 2018 10:09:50 +0800 (CST) Received: from linux-ibm.site (10.175.102.37) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.399.0; Thu, 20 Sep 2018 10:08:26 +0800 From: zhong jiang To: CC: , , , , Subject: [PATCH] net: toshiba: remove a redundant local variable 'index_specified' Date: Thu, 20 Sep 2018 09:56:05 +0800 Message-ID: <1537408565-22315-1-git-send-email-zhongjiang@huawei.com> X-Mailer: git-send-email 1.7.12.4 MIME-Version: 1.0 X-Originating-IP: [10.175.102.37] X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The local variable 'index_specified' is never used after being assigned. hence it should be redundant adn can be removed. Signed-off-by: zhong jiang --- drivers/net/ethernet/toshiba/ps3_gelic_wireless.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c b/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c index 302079e..00ab417 100644 --- a/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c +++ b/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c @@ -1094,7 +1094,7 @@ static int gelic_wl_get_encode(struct net_device *netdev, struct gelic_wl_info *wl = port_wl(netdev_priv(netdev)); struct iw_point *enc = &data->encoding; unsigned long irqflag; - unsigned int key_index, index_specified; + unsigned int key_index; int ret = 0; pr_debug("%s: <-\n", __func__); @@ -1105,13 +1105,10 @@ static int gelic_wl_get_encode(struct net_device *netdev, return -EINVAL; spin_lock_irqsave(&wl->lock, irqflag); - if (key_index) { - index_specified = 1; + if (key_index) key_index--; - } else { - index_specified = 0; + else key_index = wl->current_key; - } if (wl->group_cipher_method == GELIC_WL_CIPHER_WEP) { switch (wl->auth_method) {