| Message ID | 1537350733-44276-1-git-send-email-zhongjiang@huawei.com |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: iucv: Use FIELD_SIZEOF directly instead of reimplementing its function | expand |
On 2018/9/19 17:52, zhong jiang wrote: > FIELD_SIZEOF is defined as a macro to calculate the specified vaule. Therefore, > We prefer to use the macro rather than calculating its vaule. s/vaule/value . will resend . Thanks, zhong jiang > Signed-off-by: zhong jiang <zhongjiang@huawei.com> > --- > net/iucv/af_iucv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c > index e2f16a0..5b68ee9 100644 > --- a/net/iucv/af_iucv.c > +++ b/net/iucv/af_iucv.c > @@ -48,7 +48,7 @@ > static const u8 iprm_shutdown[8] = > {0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01}; > > -#define TRGCLS_SIZE (sizeof(((struct iucv_message *)0)->class)) > +#define TRGCLS_SIZE FIELD_SIZEOF(struct iucv_message, class) > > #define __iucv_sock_wait(sk, condition, timeo, ret) \ > do { \
diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c index e2f16a0..5b68ee9 100644 --- a/net/iucv/af_iucv.c +++ b/net/iucv/af_iucv.c @@ -48,7 +48,7 @@ static const u8 iprm_shutdown[8] = {0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01}; -#define TRGCLS_SIZE (sizeof(((struct iucv_message *)0)->class)) +#define TRGCLS_SIZE FIELD_SIZEOF(struct iucv_message, class) #define __iucv_sock_wait(sk, condition, timeo, ret) \ do { \
FIELD_SIZEOF is defined as a macro to calculate the specified vaule. Therefore, We prefer to use the macro rather than calculating its vaule. Signed-off-by: zhong jiang <zhongjiang@huawei.com> --- net/iucv/af_iucv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)