| Message ID | 1537105502-65268-1-git-send-email-zhongjiang@huawei.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: dsa: remove redundant null pointer check before put_device | expand |
From: zhong jiang <zhongjiang@huawei.com> Date: Sun, 16 Sep 2018 21:45:02 +0800 > put_device has taken the null pinter check into account. So it is > safe to remove the duplicated check before put_device. > > Signed-off-by: zhong jiang <zhongjiang@huawei.com> Applied.
diff --git a/net/dsa/legacy.c b/net/dsa/legacy.c index 42a7b85..8aa92b0 100644 --- a/net/dsa/legacy.c +++ b/net/dsa/legacy.c @@ -392,8 +392,7 @@ static void dsa_of_free_platform_data(struct dsa_platform_data *pd) } /* Drop our reference to the MDIO bus device */ - if (pd->chip[i].host_dev) - put_device(pd->chip[i].host_dev); + put_device(pd->chip[i].host_dev); } kfree(pd->chip); }
put_device has taken the null pinter check into account. So it is safe to remove the duplicated check before put_device. Signed-off-by: zhong jiang <zhongjiang@huawei.com> --- net/dsa/legacy.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)