| Message ID | 1537104017-63874-1-git-send-email-zhongjiang@huawei.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: usb: remove redundant null pointer check before of_node_put | expand |
From: zhong jiang <zhongjiang@huawei.com> Date: Sun, 16 Sep 2018 21:20:17 +0800 > of_node_put has taken the null pointer check into account. So it is > safe to remove the duplicated check before of_node_put. > > Signed-off-by: zhong jiang <zhongjiang@huawei.com> Applied.
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 3ce3c66..34ca0ee 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -1835,8 +1835,7 @@ static int lan78xx_mdio_init(struct lan78xx_net *dev) node = of_get_child_by_name(dev->udev->dev.of_node, "mdio"); ret = of_mdiobus_register(dev->mdiobus, node); - if (node) - of_node_put(node); + of_node_put(node); if (ret) { netdev_err(dev->net, "can't register MDIO bus\n"); goto exit1;
of_node_put has taken the null pointer check into account. So it is safe to remove the duplicated check before of_node_put. Signed-off-by: zhong jiang <zhongjiang@huawei.com> --- drivers/net/usb/lan78xx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)