| Message ID | 1532498773-188363-1-git-send-email-weiyongjun1@huawei.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] net: igmp: make function __ip_mc_inc_group() static | expand |
On 07/24/2018 11:06 PM, Wei Yongjun wrote: > Fixes the following sparse warnings: > > net/ipv4/igmp.c:1391:6: warning: > symbol '__ip_mc_inc_group' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > net/ipv4/igmp.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c > index 598333b..c9f8d46 100644 > --- a/net/ipv4/igmp.c > +++ b/net/ipv4/igmp.c > @@ -1388,7 +1388,8 @@ static void ip_mc_hash_remove(struct in_device *in_dev, > /* > * A socket has joined a multicast group on device dev. > */ > -void __ip_mc_inc_group(struct in_device *in_dev, __be32 addr, unsigned int mode) > +static void __ip_mc_inc_group(struct in_device *in_dev, __be32 addr, > + unsigned int mode) > { > struct ip_mc_list *im; > #ifdef CONFIG_IP_MULTICAST > This should target net tree Fixes: 6e2059b53f98 ("ipv4/igmp: init group mode as INCLUDE when join source group")
From: Wei Yongjun <weiyongjun1@huawei.com> Date: Wed, 25 Jul 2018 06:06:13 +0000 > Fixes the following sparse warnings: > > net/ipv4/igmp.c:1391:6: warning: > symbol '__ip_mc_inc_group' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Applied to 'net'.
diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c index 598333b..c9f8d46 100644 --- a/net/ipv4/igmp.c +++ b/net/ipv4/igmp.c @@ -1388,7 +1388,8 @@ static void ip_mc_hash_remove(struct in_device *in_dev, /* * A socket has joined a multicast group on device dev. */ -void __ip_mc_inc_group(struct in_device *in_dev, __be32 addr, unsigned int mode) +static void __ip_mc_inc_group(struct in_device *in_dev, __be32 addr, + unsigned int mode) { struct ip_mc_list *im; #ifdef CONFIG_IP_MULTICAST
Fixes the following sparse warnings: net/ipv4/igmp.c:1391:6: warning: symbol '__ip_mc_inc_group' was not declared. Should it be static? Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- net/ipv4/igmp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)