| Message ID | 1530092857-73580-1-git-send-email-weiyongjun1@huawei.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | hinic: reset irq affinity before freeing irq | expand |
From: Wei Yongjun <weiyongjun1@huawei.com> Date: Wed, 27 Jun 2018 17:47:37 +0800 > Following warning is seen when rmmod hinic. This is because affinity > value is not reset before calling free_irq(). This patch fixes it. > > [ 55.181232] WARNING: CPU: 38 PID: 19589 at kernel/irq/manage.c:1608 > __free_irq+0x2aa/0x2c0 > > Fixes: 352f58b0d9f2 ("net-next/hinic: Set Rxq irq to specific cpu for NUMA") > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Applied and queued up for -stable.
diff --git a/drivers/net/ethernet/huawei/hinic/hinic_rx.c b/drivers/net/ethernet/huawei/hinic/hinic_rx.c index e2e5cdc..4c0f7ed 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_rx.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_rx.c @@ -439,6 +439,7 @@ static void rx_free_irq(struct hinic_rxq *rxq) { struct hinic_rq *rq = rxq->rq; + irq_set_affinity_hint(rq->irq, NULL); free_irq(rq->irq, rxq); rx_del_napi(rxq); }
Following warning is seen when rmmod hinic. This is because affinity value is not reset before calling free_irq(). This patch fixes it. [ 55.181232] WARNING: CPU: 38 PID: 19589 at kernel/irq/manage.c:1608 __free_irq+0x2aa/0x2c0 Fixes: 352f58b0d9f2 ("net-next/hinic: Set Rxq irq to specific cpu for NUMA") Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>