| Message ID | 1524650077-13270-1-git-send-email-krzk@kernel.org |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [stable,v4.4+] r8152: add Linksys USB3GIGV1 id | expand |
On Wed, Apr 25, 2018 at 11:54:37AM +0200, Krzysztof Kozlowski wrote: > commit 90841047a01b452cc8c3f9b990698b264143334a upstream > > This linksys dongle by default comes up in cdc_ether mode. > This patch allows r8152 to claim the device: > Bus 002 Device 002: ID 13b1:0041 Linksys > > Signed-off-by: Grant Grundler <grundler@chromium.org> > Reviewed-by: Douglas Anderson <dianders@chromium.org> > Signed-off-by: David S. Miller <davem@davemloft.net> > [krzk: Rebase on v4.4] Also added to 4.9.y, thanks. greg k-h
On Wed, Apr 25, 2018 at 2:54 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote: > commit 90841047a01b452cc8c3f9b990698b264143334a upstream > > This linksys dongle by default comes up in cdc_ether mode. > This patch allows r8152 to claim the device: > Bus 002 Device 002: ID 13b1:0041 Linksys > > Signed-off-by: Grant Grundler <grundler@chromium.org> > Reviewed-by: Douglas Anderson <dianders@chromium.org> > Signed-off-by: David S. Miller <davem@davemloft.net> > [krzk: Rebase on v4.4] > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> thanks krzk! FTR, to support RTL8153B (HW ID 0x6010), the follow patch series to bring r8152 v1.09.9 driver from 4.14 kernel.org to 3 (of 5) older Chrome OS kernels: 3.14: https://chromium-review.googlesource.com/q/topic:%22update_r8152-3.14%22+(status:open%20OR%20status:merged) 3.18: https://chromium-review.googlesource.com/q/topic:%2522update-r8152-3.18%2522+(status:open+OR+status:merged) 4.4: https://chromium-review.googlesource.com/q/topic:%2522update_r8152-4.4%2522+(status:open+OR+status:merged) caveat: These series are not suitable directly for kernel.org submission (extraneous stuff in the commit messages, order is different). Using the original SHA1 (in each commit message), this can all be fixed up by hand/simple scripts. cheers, grant > --- > drivers/net/usb/cdc_ether.c | 10 ++++++++++ > drivers/net/usb/r8152.c | 2 ++ > 2 files changed, 12 insertions(+) > > diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c > index 6578127db847..f71abe50ea6f 100644 > --- a/drivers/net/usb/cdc_ether.c > +++ b/drivers/net/usb/cdc_ether.c > @@ -461,6 +461,7 @@ static const struct driver_info wwan_info = { > #define REALTEK_VENDOR_ID 0x0bda > #define SAMSUNG_VENDOR_ID 0x04e8 > #define LENOVO_VENDOR_ID 0x17ef > +#define LINKSYS_VENDOR_ID 0x13b1 > #define NVIDIA_VENDOR_ID 0x0955 > #define HP_VENDOR_ID 0x03f0 > > @@ -650,6 +651,15 @@ static const struct usb_device_id products[] = { > .driver_info = 0, > }, > > +#if IS_ENABLED(CONFIG_USB_RTL8152) > +/* Linksys USB3GIGV1 Ethernet Adapter */ > +{ > + USB_DEVICE_AND_INTERFACE_INFO(LINKSYS_VENDOR_ID, 0x0041, USB_CLASS_COMM, > + USB_CDC_SUBCLASS_ETHERNET, USB_CDC_PROTO_NONE), > + .driver_info = 0, > +}, > +#endif > + > /* Lenovo Thinkpad USB 3.0 Ethernet Adapters (based on Realtek RTL8153) */ > { > USB_DEVICE_AND_INTERFACE_INFO(LENOVO_VENDOR_ID, 0x7205, USB_CLASS_COMM, > diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c > index 89950f5cea71..b2c1a435357f 100644 > --- a/drivers/net/usb/r8152.c > +++ b/drivers/net/usb/r8152.c > @@ -506,6 +506,7 @@ enum rtl8152_flags { > #define VENDOR_ID_REALTEK 0x0bda > #define VENDOR_ID_SAMSUNG 0x04e8 > #define VENDOR_ID_LENOVO 0x17ef > +#define VENDOR_ID_LINKSYS 0x13b1 > #define VENDOR_ID_NVIDIA 0x0955 > > #define MCU_TYPE_PLA 0x0100 > @@ -4376,6 +4377,7 @@ static struct usb_device_id rtl8152_table[] = { > {REALTEK_USB_DEVICE(VENDOR_ID_SAMSUNG, 0xa101)}, > {REALTEK_USB_DEVICE(VENDOR_ID_LENOVO, 0x7205)}, > {REALTEK_USB_DEVICE(VENDOR_ID_LENOVO, 0x304f)}, > + {REALTEK_USB_DEVICE(VENDOR_ID_LINKSYS, 0x0041)}, > {REALTEK_USB_DEVICE(VENDOR_ID_NVIDIA, 0x09ff)}, > {} > }; > -- > 2.7.4 >
On Thu, Apr 26, 2018 at 2:40 AM, Grant Grundler <grundler@chromium.org> wrote: > On Wed, Apr 25, 2018 at 2:54 AM, Krzysztof Kozlowski <krzk@kernel.org> > wrote: >> >> commit 90841047a01b452cc8c3f9b990698b264143334a upstream >> >> This linksys dongle by default comes up in cdc_ether mode. >> This patch allows r8152 to claim the device: >> Bus 002 Device 002: ID 13b1:0041 Linksys >> >> Signed-off-by: Grant Grundler <grundler@chromium.org> >> Reviewed-by: Douglas Anderson <dianders@chromium.org> >> Signed-off-by: David S. Miller <davem@davemloft.net> >> [krzk: Rebase on v4.4]' > > > thanks krzk! > > FTR, to support RTL8153B (HW ID 0x6010), the follow patch series to bring > r8152 v1.09.9 driver from 4.14 kernel.org to 3 (of 5) older Chrome OS > kernels: > > 3.14: > https://chromium-review.googlesource.com/q/topic:%22update_r8152-3.14%22+(status:open%20OR%20status:merged) > 3.18: > https://chromium-review.googlesource.com/q/topic:%2522update-r8152-3.18%2522+(status:open+OR+status:merged) > 4.4: > https://chromium-review.googlesource.com/q/topic:%2522update_r8152-4.4%2522+(status:open+OR+status:merged) > > caveat: These series are not suitable directly for kernel.org submission > (extraneous stuff in the commit messages, order is different). Using the > original SHA1 (in each commit message), this can all be fixed up by > hand/simple scripts. Hi Grant, These are regular feature/patch backports so they do not fit into stable process. Only new quirks and IDs are accepted for stable. Best regards, Krzysztof
On Thu, Apr 26, 2018 at 12:56 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote: > On Thu, Apr 26, 2018 at 2:40 AM, Grant Grundler <grundler@chromium.org> wrote: >> On Wed, Apr 25, 2018 at 2:54 AM, Krzysztof Kozlowski <krzk@kernel.org> >> wrote: >>> >>> commit 90841047a01b452cc8c3f9b990698b264143334a upstream >>> >>> This linksys dongle by default comes up in cdc_ether mode. >>> This patch allows r8152 to claim the device: >>> Bus 002 Device 002: ID 13b1:0041 Linksys >>> >>> Signed-off-by: Grant Grundler <grundler@chromium.org> >>> Reviewed-by: Douglas Anderson <dianders@chromium.org> >>> Signed-off-by: David S. Miller <davem@davemloft.net> >>> [krzk: Rebase on v4.4]' >> >> >> thanks krzk! >> >> FTR, to support RTL8153B (HW ID 0x6010), the follow patch series to bring >> r8152 v1.09.9 driver from 4.14 kernel.org to 3 (of 5) older Chrome OS >> kernels: >> >> 3.14: >> https://chromium-review.googlesource.com/q/topic:%22update_r8152-3.14%22+(status:open%20OR%20status:merged) >> 3.18: >> https://chromium-review.googlesource.com/q/topic:%2522update-r8152-3.18%2522+(status:open+OR+status:merged) >> 4.4: >> https://chromium-review.googlesource.com/q/topic:%2522update_r8152-4.4%2522+(status:open+OR+status:merged) >> >> caveat: These series are not suitable directly for kernel.org submission >> (extraneous stuff in the commit messages, order is different). Using the >> original SHA1 (in each commit message), this can all be fixed up by >> hand/simple scripts. > > Hi Grant, > > These are regular feature/patch backports so they do not fit into > stable process. Only new quirks and IDs are accepted for stable. Hi Krzysztof! Sorry, I wasn't advocating for -stable inclusion. I shared in case someone has unusually high USB ethernet requirements similar to Chrome OS test lab which nearly all dongles I've tested can't provide. Chrome OS test lab needs a USB ethernet dongle that reliably negotiates a link (e.g. 10k iterations in a row). RTL8153 in general are good (> 99.99% gets GigE link speed) but RTL8153B is the first dongle that meets Chrome OS test lab requirements. The patch series above is required to support RTL8153B. cheers, grant
diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c index 6578127db847..f71abe50ea6f 100644 --- a/drivers/net/usb/cdc_ether.c +++ b/drivers/net/usb/cdc_ether.c @@ -461,6 +461,7 @@ static const struct driver_info wwan_info = { #define REALTEK_VENDOR_ID 0x0bda #define SAMSUNG_VENDOR_ID 0x04e8 #define LENOVO_VENDOR_ID 0x17ef +#define LINKSYS_VENDOR_ID 0x13b1 #define NVIDIA_VENDOR_ID 0x0955 #define HP_VENDOR_ID 0x03f0 @@ -650,6 +651,15 @@ static const struct usb_device_id products[] = { .driver_info = 0, }, +#if IS_ENABLED(CONFIG_USB_RTL8152) +/* Linksys USB3GIGV1 Ethernet Adapter */ +{ + USB_DEVICE_AND_INTERFACE_INFO(LINKSYS_VENDOR_ID, 0x0041, USB_CLASS_COMM, + USB_CDC_SUBCLASS_ETHERNET, USB_CDC_PROTO_NONE), + .driver_info = 0, +}, +#endif + /* Lenovo Thinkpad USB 3.0 Ethernet Adapters (based on Realtek RTL8153) */ { USB_DEVICE_AND_INTERFACE_INFO(LENOVO_VENDOR_ID, 0x7205, USB_CLASS_COMM, diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 89950f5cea71..b2c1a435357f 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -506,6 +506,7 @@ enum rtl8152_flags { #define VENDOR_ID_REALTEK 0x0bda #define VENDOR_ID_SAMSUNG 0x04e8 #define VENDOR_ID_LENOVO 0x17ef +#define VENDOR_ID_LINKSYS 0x13b1 #define VENDOR_ID_NVIDIA 0x0955 #define MCU_TYPE_PLA 0x0100 @@ -4376,6 +4377,7 @@ static struct usb_device_id rtl8152_table[] = { {REALTEK_USB_DEVICE(VENDOR_ID_SAMSUNG, 0xa101)}, {REALTEK_USB_DEVICE(VENDOR_ID_LENOVO, 0x7205)}, {REALTEK_USB_DEVICE(VENDOR_ID_LENOVO, 0x304f)}, + {REALTEK_USB_DEVICE(VENDOR_ID_LINKSYS, 0x0041)}, {REALTEK_USB_DEVICE(VENDOR_ID_NVIDIA, 0x09ff)}, {} };