| Message ID | 1524582120-4451-3-git-send-email-christophe.roullier@st.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: ethernet: stmmac: add support for stm32mp1 | expand |
On Tue, Apr 24, 2018 at 05:01:54PM +0200, Christophe Roullier wrote: > Add description for Ethernet MPU families fields > > Signed-off-by: Christophe Roullier <christophe.roullier@st.com> > --- > Documentation/devicetree/bindings/net/stm32-dwmac.txt | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.txt b/Documentation/devicetree/bindings/net/stm32-dwmac.txt > index 489dbcb..e9d1c4a 100644 > --- a/Documentation/devicetree/bindings/net/stm32-dwmac.txt > +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.txt > @@ -6,14 +6,26 @@ Please see stmmac.txt for the other unchanged properties. > The device node has following properties. > > Required properties: > -- compatible: Should be "st,stm32-dwmac" to select glue, and > +- compatible: For MCU family should be "st,stm32-dwmac" to select glue, and > "snps,dwmac-3.50a" to select IP version. > + For MPU family should be "st,stm32mp1-dwmac" to select > + glue, and "snps,dwmac-4.20a" to select IP version. > - clocks: Must contain a phandle for each entry in clock-names. > - clock-names: Should be "stmmaceth" for the host clock. > Should be "mac-clk-tx" for the MAC TX clock. > Should be "mac-clk-rx" for the MAC RX clock. > + For MPU family "ethstp" for power mode clock. > + For MPU family need also "syscfg-clk" for SYSCFG clock. These are in addition or instead of the first 3 clocks. > +- interrupt-names: Should contain a list of interrupt names corresponding to > + the interrupts in the interrupts property, if available. You need to list the names. Seems unrelated to MPU support. > - st,syscon : Should be phandle/offset pair. The phandle to the syscon node which > - encompases the glue register, and the offset of the control register. > + encompases the glue register, and the offset of the control register. > + > +Optional properties: > +- clock-names: For MPU family "mac-clk-ck" for PHY without quartz The clock is always connected whether you use it or not, right? So it shouldn't be optional based on use. > +- st,int-phyclk : valid only where PHY do not have quartz and need to be clock > + by RCC Boolean? > + > Example: > > ethernet@40028000 { > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, My answers below under "CRO" Thanks. Christophe -----Original Message----- From: Rob Herring [mailto:robh@kernel.org] Sent: mardi 1 mai 2018 15:59 To: Christophe ROULLIER <christophe.roullier@st.com> Cc: mark.rutland@arm.com; mcoquelin.stm32@gmail.com; Alexandre TORGUE <alexandre.torgue@st.com>; Peppe CAVALLARO <peppe.cavallaro@st.com>; devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; netdev@vger.kernel.org Subject: Re: [PATCH 2/8] dt-bindings: stm32-dwmac: add support of MPU families On Tue, Apr 24, 2018 at 05:01:54PM +0200, Christophe Roullier wrote: > Add description for Ethernet MPU families fields > > Signed-off-by: Christophe Roullier <christophe.roullier@st.com> > --- > Documentation/devicetree/bindings/net/stm32-dwmac.txt | 16 > ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.txt > b/Documentation/devicetree/bindings/net/stm32-dwmac.txt > index 489dbcb..e9d1c4a 100644 > --- a/Documentation/devicetree/bindings/net/stm32-dwmac.txt > +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.txt > @@ -6,14 +6,26 @@ Please see stmmac.txt for the other unchanged properties. > The device node has following properties. > > Required properties: > -- compatible: Should be "st,stm32-dwmac" to select glue, and > +- compatible: For MCU family should be "st,stm32-dwmac" to select > +glue, and > "snps,dwmac-3.50a" to select IP version. > + For MPU family should be "st,stm32mp1-dwmac" to select > + glue, and "snps,dwmac-4.20a" to select IP version. > - clocks: Must contain a phandle for each entry in clock-names. > - clock-names: Should be "stmmaceth" for the host clock. > Should be "mac-clk-tx" for the MAC TX clock. > Should be "mac-clk-rx" for the MAC RX clock. > + For MPU family "ethstp" for power mode clock. > + For MPU family need also "syscfg-clk" for SYSCFG clock. These are in addition or instead of the first 3 clocks. CRO: This is in addition of the first 3 clocks, I will modified my comment: >> - clock-names: Should be "stmmaceth" for the host clock. >> Should be "mac-clk-tx" for the MAC TX clock. >> Should be "mac-clk-rx" for the MAC RX clock. >> + For MPU family need to add also "ethstp" for power mode clock and, >> + "syscfg-clk" for SYSCFG clock. > +- interrupt-names: Should contain a list of interrupt names corresponding to > + the interrupts in the interrupts property, if available. You need to list the names. Seems unrelated to MPU support. CRO: > +- interrupt-names: Should contain a list of interrupt names corresponding to > + the interrupts in the interrupts property, if available. + Should be "macirq" for the main MAC IT + Should be "eth_wake_irq" for the IT which wake up system > - st,syscon : Should be phandle/offset pair. The phandle to the syscon node which > - encompases the glue register, and the offset of the control register. > + encompases the glue register, and the offset of the control register. > + > +Optional properties: > +- clock-names: For MPU family "mac-clk-ck" for PHY without quartz The clock is always connected whether you use it or not, right? So it shouldn't be optional based on use. CRO: Yes the clock is always connected but it is not necessary to enable it if you have phy with quartz (it will not use) So it is optional. > +- st,int-phyclk : valid only where PHY do not have quartz and need to be clock > + by RCC Boolean? CRO: Yes > +- st,int-phyclk (boolean) : valid only where PHY do not have quartz and need to be clock Is it ok ? > + > Example: > > ethernet@40028000 { > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" > in the body of a message to majordomo@vger.kernel.org More majordomo > info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.txt b/Documentation/devicetree/bindings/net/stm32-dwmac.txt index 489dbcb..e9d1c4a 100644 --- a/Documentation/devicetree/bindings/net/stm32-dwmac.txt +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.txt @@ -6,14 +6,26 @@ Please see stmmac.txt for the other unchanged properties. The device node has following properties. Required properties: -- compatible: Should be "st,stm32-dwmac" to select glue, and +- compatible: For MCU family should be "st,stm32-dwmac" to select glue, and "snps,dwmac-3.50a" to select IP version. + For MPU family should be "st,stm32mp1-dwmac" to select + glue, and "snps,dwmac-4.20a" to select IP version. - clocks: Must contain a phandle for each entry in clock-names. - clock-names: Should be "stmmaceth" for the host clock. Should be "mac-clk-tx" for the MAC TX clock. Should be "mac-clk-rx" for the MAC RX clock. + For MPU family "ethstp" for power mode clock. + For MPU family need also "syscfg-clk" for SYSCFG clock. +- interrupt-names: Should contain a list of interrupt names corresponding to + the interrupts in the interrupts property, if available. - st,syscon : Should be phandle/offset pair. The phandle to the syscon node which - encompases the glue register, and the offset of the control register. + encompases the glue register, and the offset of the control register. + +Optional properties: +- clock-names: For MPU family "mac-clk-ck" for PHY without quartz +- st,int-phyclk : valid only where PHY do not have quartz and need to be clock + by RCC + Example: ethernet@40028000 {
Add description for Ethernet MPU families fields Signed-off-by: Christophe Roullier <christophe.roullier@st.com> --- Documentation/devicetree/bindings/net/stm32-dwmac.txt | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-)