| Message ID | 1524092579-15625-2-git-send-email-andrew@lunn.ch |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | Modernize mdio-gpio | expand |
From: Andrew Lunn <andrew@lunn.ch> Date: Thu, 19 Apr 2018 01:02:49 +0200 > @@ -161,7 +161,7 @@ static struct mii_bus *mdio_gpio_bus_init(struct device *dev, > if (!new_bus) > goto out; > > - new_bus->name = "GPIO Bitbanged MDIO", > + new_bus->name = "GPIO Bitbanged MDIO"; Would be so great to find a way to automatically detect these somehow. Yes, they are useful when controlling evaluation in weird ways in macros etc. However most of the time if a ',' is used in a context where a ';' also works, it's unintentional.
diff --git a/drivers/net/phy/mdio-gpio.c b/drivers/net/phy/mdio-gpio.c index 4333c6e14742..369f5f35d6fd 100644 --- a/drivers/net/phy/mdio-gpio.c +++ b/drivers/net/phy/mdio-gpio.c @@ -161,7 +161,7 @@ static struct mii_bus *mdio_gpio_bus_init(struct device *dev, if (!new_bus) goto out; - new_bus->name = "GPIO Bitbanged MDIO", + new_bus->name = "GPIO Bitbanged MDIO"; new_bus->phy_mask = pdata->phy_mask; new_bus->phy_ignore_ta_mask = pdata->phy_ignore_ta_mask;
Seems like an old typ0. Signed-off-by: Andrew Lunn <andrew@lunn.ch> --- drivers/net/phy/mdio-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)