From patchwork Wed Apr 18 04:26:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Schmitz X-Patchwork-Id: 899869 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="lRlrthiC"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40QpxZ1MyBz9s1t for ; Wed, 18 Apr 2018 14:27:30 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753727AbeDRE1N (ORCPT ); Wed, 18 Apr 2018 00:27:13 -0400 Received: from mail-pl0-f65.google.com ([209.85.160.65]:44386 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753436AbeDRE1K (ORCPT ); Wed, 18 Apr 2018 00:27:10 -0400 Received: by mail-pl0-f65.google.com with SMTP id s13-v6so320587plq.11; Tue, 17 Apr 2018 21:27:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=OWk3jcfirx1lY2HqwufBJ20iycZ1SDfFVyaG1YaFYY0=; b=lRlrthiCM4rqf/LYoTLJabTtNJUcsR3Dsdr8Kb40lN7UX1TPkbYW/kv/LsCjh3MMcO wjCGWBj+VIVUxb+A/upFLiYmzg6P6tOJxog+8koVasuASIhsEj2vrw6bq+ILFRLZgNP0 tG9phRLywj6AAc5YAq5ROhP/UjVfGUsj1eqU7NOgI+7XAQ6j7DU+pdiekjeDilQJTMSW 2FuUpIBTUjn79x1YZWJaKmOWwdBpI3vL0+nGBezskAk6n4VzpAI/MaoC4c8zibqqxAEU MC71hfrL9TYumKYbbOToBoP4C0Q3cQ1d9GBo0vMJFkFtBBxYVd5H7+QN/v4cmQp9HuW5 WzWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=OWk3jcfirx1lY2HqwufBJ20iycZ1SDfFVyaG1YaFYY0=; b=pdk4frvPeuUSChCOYXdflYDiRef6u3kGujZl/S4PjG/uDR2hcei2VXi9zkFL3+vHrd E/9unzTo+4S0SSGKmM0v80zJDgY48ZsmSTMtimiNicHpPVLsgDv3CBRzUacoz2sSrDzZ vs8FitdJ+QacufKsqiC9P8tR0F/0+AGJhrjd7TJDv97pNXslunCv1g+0FMHj6PLO7nBF GPx3kQq81oI3yM+3QhfXBrvohIiqTHGEMWdrNN8YViTme/lBHSmaE95hqpLKTIHwmJJ9 a2Sr8ujWhtj3IwrMERL31CF+ZAPxLvhMu9AmDXwnzsNF7m51azt5vCtHFcLe2MPgF5BA e22Q== X-Gm-Message-State: ALQs6tCtjjDFLQF4DDEYyrTqWub6IQJ+EIBNp7p8MttZrkEn+oW+hyrX PY2HexpNsJMwEGdv0KwDWks= X-Google-Smtp-Source: AIpwx4/jbeJ4oP1vnRij8ps+//t6zMZWsBhxTaU68igMmeEb+OjQjOgFbkQjbLCfCgDwBWYQOKDCEQ== X-Received: by 2002:a17:902:b60f:: with SMTP id b15-v6mr609454pls.12.1524025629817; Tue, 17 Apr 2018 21:27:09 -0700 (PDT) Received: from xplor.waratah.dyndns.org (222-154-41-72-adsl.bb.spark.co.nz. [222.154.41.72]) by smtp.gmail.com with ESMTPSA id e73sm769877pfj.186.2018.04.17.21.27.07 (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 17 Apr 2018 21:27:07 -0700 (PDT) Received: by xplor.waratah.dyndns.org (Postfix, from userid 1000) id DCEC236008B; Wed, 18 Apr 2018 16:26:58 +1200 (NZST) From: Michael Schmitz To: netdev@vger.kernel.org Cc: andrew@lunn.ch, fthain@telegraphics.com.au, geert@linux-m68k.org, f.fainelli@gmail.com, linux-m68k@vger.kernel.org, Michael.Karcher@fu-berlin.de, Michael Schmitz Subject: [PATCH v3 8/9] net: ax88796: release platform device drvdata on probe error and module remove Date: Wed, 18 Apr 2018 16:26:55 +1200 Message-Id: <1524025616-3722-9-git-send-email-schmitzmic@gmail.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <1523930895-6973-1-git-send-email-schmitzmic@gmail.com> References: <1523930895-6973-1-git-send-email-schmitzmic@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The net device struct pointer is stored as platform device drvdata on module probe - clear the drvdata entry on probe fail there, as well as when unloading the module. Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/8390/ax88796.c b/drivers/net/ethernet/8390/ax88796.c index a72dfbc..eb72282 100644 --- a/drivers/net/ethernet/8390/ax88796.c +++ b/drivers/net/ethernet/8390/ax88796.c @@ -829,6 +829,7 @@ static int ax_remove(struct platform_device *pdev) release_mem_region(mem->start, resource_size(mem)); } + platform_set_drvdata(pdev, NULL); free_netdev(dev); return 0; @@ -962,6 +963,7 @@ static int ax_probe(struct platform_device *pdev) release_mem_region(mem->start, mem_size); exit_mem: + platform_set_drvdata(pdev, NULL); free_netdev(dev); return ret;