From patchwork Fri Mar 16 16:16:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 886961 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=codeaurora.org header.i=@codeaurora.org header.b="Z5dx5Ft6"; dkim=pass (1024-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="Z5dx5Ft6"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 402rNS3Dk5z9s9y for ; Sat, 17 Mar 2018 03:23:04 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752217AbeCPQWu (ORCPT ); Fri, 16 Mar 2018 12:22:50 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:39714 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934727AbeCPQRG (ORCPT ); Fri, 16 Mar 2018 12:17:06 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id E072960390; Fri, 16 Mar 2018 16:17:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521217025; bh=k286ILLDOEaleKNkYdeXfmnzFmqrz4oZGuI5cDKa90c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z5dx5Ft677Q1l+5gPpgcXMvs4v3Q/GoS2VgX1XYh4CCC9o0OE6NOy8uhxiUN9RA25 Bc69NEnPmSPQAw7A7zbWpv1itGZ0fyGx2I79d51iCmm8R7ApQdxuBeOFeVMGS74uK8 kcRGNUfSPiLc5zE+Y8ptfPhNiY5M8kwGssahUZhY= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED, T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1ADCD60D81; Fri, 16 Mar 2018 16:17:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521217025; bh=k286ILLDOEaleKNkYdeXfmnzFmqrz4oZGuI5cDKa90c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z5dx5Ft677Q1l+5gPpgcXMvs4v3Q/GoS2VgX1XYh4CCC9o0OE6NOy8uhxiUN9RA25 Bc69NEnPmSPQAw7A7zbWpv1itGZ0fyGx2I79d51iCmm8R7ApQdxuBeOFeVMGS74uK8 kcRGNUfSPiLc5zE+Y8ptfPhNiY5M8kwGssahUZhY= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1ADCD60D81 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: netdev@vger.kernel.org, timur@codeaurora.org, sulrich@codeaurora.org Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sinan Kaya , Harish Patil , Manish Chopra , Dept-GELinuxNICDev@cavium.com, linux-kernel@vger.kernel.org Subject: [PATCH v3 11/18] qlcnic: Eliminate duplicate barriers on weakly-ordered archs Date: Fri, 16 Mar 2018 12:16:24 -0400 Message-Id: <1521216991-28706-12-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1521216991-28706-1-git-send-email-okaya@codeaurora.org> References: <1521216991-28706-1-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Code includes wmb() followed by writel(). writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Since code already has an explicit barrier call, changing writel() to writel_relaxed(). Signed-off-by: Sinan Kaya Acked-by: Manish Chopra --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c index 46b0372..97c146e7 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c @@ -478,7 +478,7 @@ irqreturn_t qlcnic_83xx_clear_legacy_intr(struct qlcnic_adapter *adapter) wmb(); /* clear the interrupt trigger control register */ - writel(0, adapter->isr_int_vec); + writel_relaxed(0, adapter->isr_int_vec); intr_val = readl(adapter->isr_int_vec); do { intr_val = readl(adapter->tgt_status_reg);