| Message ID | 1517922354-28421-2-git-send-email-geert+renesas@glider.be |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [1/3] dt-bindings: net: renesas-ravb: Make stream buffer optional | expand |
On Tue, Feb 06, 2018 at 02:05:52PM +0100, Geert Uytterhoeven wrote: > The Stream Buffer for EtherAVB-IF (STBE) is an optional component, and > is not present on all SoCs. > > Document this in the DT bindings, including a list of SoCs that do have > it. > > Fixes: 785ec87483d1e24a ("ravb: document R8A77970 bindings") > Fixes: f231c4178a655b09 ("dt-bindings: net: renesas-ravb: Add support for R8A77995 RAVB") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
On 02/06/2018 04:05 PM, Geert Uytterhoeven wrote: > The Stream Buffer for EtherAVB-IF (STBE) is an optional component, and > is not present on all SoCs. > > Document this in the DT bindings, including a list of SoCs that do have > it. > > Fixes: 785ec87483d1e24a ("ravb: document R8A77970 bindings") > Fixes: f231c4178a655b09 ("dt-bindings: net: renesas-ravb: Add support for R8A77995 RAVB") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > --- > Documentation/devicetree/bindings/net/renesas,ravb.txt | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt > index c902261893b913f5..296191c323a64403 100644 > --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt > +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt > @@ -26,7 +26,10 @@ Required properties: > SoC-specific version corresponding to the platform first followed by > the generic version. > > -- reg: offset and length of (1) the register block and (2) the stream buffer. > +- reg: Offset and length of (1) the register block and (2) the stream buffer. > + The region for the register block is mandatory. > + The region for the stream buffer is optional, as it is only present on > + R-Car Gen2, RZ/G1, and R-Car H3 and M3-W. Did you deliberately omit M3-N for now? MBR, Sergei
Hi Sergei, On Tue, Feb 6, 2018 at 3:56 PM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > On 02/06/2018 04:05 PM, Geert Uytterhoeven wrote: >> The Stream Buffer for EtherAVB-IF (STBE) is an optional component, and >> is not present on all SoCs. >> >> Document this in the DT bindings, including a list of SoCs that do have >> it. >> >> Fixes: 785ec87483d1e24a ("ravb: document R8A77970 bindings") >> Fixes: f231c4178a655b09 ("dt-bindings: net: renesas-ravb: Add support for R8A77995 RAVB") >> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Thanks! >> --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt >> +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt >> @@ -26,7 +26,10 @@ Required properties: >> SoC-specific version corresponding to the platform first followed by >> the generic version. >> >> -- reg: offset and length of (1) the register block and (2) the stream buffer. >> +- reg: Offset and length of (1) the register block and (2) the stream buffer. >> + The region for the register block is mandatory. >> + The region for the stream buffer is optional, as it is only present on >> + R-Car Gen2, RZ/G1, and R-Car H3 and M3-W. > > Did you deliberately omit M3-N for now? Of course. It's not yet upstream. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Tue, Feb 06, 2018 at 02:05:52PM +0100, Geert Uytterhoeven wrote: > The Stream Buffer for EtherAVB-IF (STBE) is an optional component, and > is not present on all SoCs. > > Document this in the DT bindings, including a list of SoCs that do have > it. > > Fixes: 785ec87483d1e24a ("ravb: document R8A77970 bindings") > Fixes: f231c4178a655b09 ("dt-bindings: net: renesas-ravb: Add support for R8A77995 RAVB") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > Documentation/devicetree/bindings/net/renesas,ravb.txt | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt index c902261893b913f5..296191c323a64403 100644 --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt @@ -26,7 +26,10 @@ Required properties: SoC-specific version corresponding to the platform first followed by the generic version. -- reg: offset and length of (1) the register block and (2) the stream buffer. +- reg: Offset and length of (1) the register block and (2) the stream buffer. + The region for the register block is mandatory. + The region for the stream buffer is optional, as it is only present on + R-Car Gen2, RZ/G1, and R-Car H3 and M3-W. - interrupts: A list of interrupt-specifiers, one for each entry in interrupt-names. If interrupt-names is not present, an interrupt specifier
The Stream Buffer for EtherAVB-IF (STBE) is an optional component, and is not present on all SoCs. Document this in the DT bindings, including a list of SoCs that do have it. Fixes: 785ec87483d1e24a ("ravb: document R8A77970 bindings") Fixes: f231c4178a655b09 ("dt-bindings: net: renesas-ravb: Add support for R8A77995 RAVB") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- Documentation/devicetree/bindings/net/renesas,ravb.txt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)