| Message ID | 1516110120-32132-3-git-send-email-galp@mellanox.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | stephen hemminger |
| Headers | show |
| Series | Fixes for minimum/maximum VF rate API | expand |
diff --git a/ip/ipaddress.c b/ip/ipaddress.c index f150d91..953d673 100644 --- a/ip/ipaddress.c +++ b/ip/ipaddress.c @@ -2251,6 +2251,12 @@ ipaddr_loop_each_vf(struct rtattr *tb[], int vfnum, int *min, int *max) for (i = RTA_DATA(vflist); RTA_OK(i, rem); i = RTA_NEXT(i, rem)) { parse_rtattr_nested(vf, IFLA_VF_MAX, i); + + if (!vf[IFLA_VF_RATE]) { + fprintf(stderr, "VF min/max rate API not supported\n"); + exit(1); + } + vf_rate = RTA_DATA(vf[IFLA_VF_RATE]); if (vf_rate->vf == vfnum) { *min = vf_rate->min_tx_rate;
When using the new minimum rate API and providing only one parameter (minimum rate/maximum rate), we query the VF min and max rate regardless of kernel support. This resulted in segmentation fault in ipaddr_loop_each_vf, which tries to access NULL pointer. This patch identifies such cases by testing the VF table for NULL pointer in IFLA_VF_RATE, and aborts the operation. Aborting on the first VF is valid since if the kernel does not support the new API for the first VF, it will not support it for the other VFs as well. Fixes: f89a2a05ffa9 ("Add support to configure SR-IOV VF minimum and maximum Tx rate through ip tool") Cc: Sucheta Chakraborty <sucheta.chakraborty@qlogic.com> Signed-off-by: Gal Pressman <galp@mellanox.com> Reviewed-by: Eran Ben Elisha <eranbe@mellanox.com> Reviewed-by: Leon Romanovsky <leonro@mellanox.com> --- ip/ipaddress.c | 6 ++++++ 1 file changed, 6 insertions(+)