From patchwork Wed Jan 3 21:42:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Subash Abhinov Kasiviswanathan X-Patchwork-Id: 855280 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=codeaurora.org header.i=@codeaurora.org header.b="XSjKPhTg"; dkim=pass (1024-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="XSjKPhTg"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zBkyd3BQTz9s7g for ; Thu, 4 Jan 2018 08:46:17 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751391AbeACVpv (ORCPT ); Wed, 3 Jan 2018 16:45:51 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:57190 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751323AbeACVpn (ORCPT ); Wed, 3 Jan 2018 16:45:43 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 8C34060850; Wed, 3 Jan 2018 21:45:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1515015943; bh=HQEKXzu6w4HG5WqecWxYAkp/iCWF8JyKh30YoKmEVyY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XSjKPhTgp1mCP+siXn08356PlvT3F8vzjRvsyed6vcoaJOa+hQF3j53paDQEHdhrP aS4nMjylgAC+oxvKDqNoY2oKhZChGBOX0kLO4NsC6SYHTwIK14/dKUmdUBlCiwqYRY prLyzuDlWXlZLt1htt3YbfCR/3CK6wzgXXiEOcAU= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED, T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from subashab-lnx.qualcomm.com (unknown [129.46.15.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: subashab@codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id C38AC60314; Wed, 3 Jan 2018 21:45:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1515015943; bh=HQEKXzu6w4HG5WqecWxYAkp/iCWF8JyKh30YoKmEVyY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XSjKPhTgp1mCP+siXn08356PlvT3F8vzjRvsyed6vcoaJOa+hQF3j53paDQEHdhrP aS4nMjylgAC+oxvKDqNoY2oKhZChGBOX0kLO4NsC6SYHTwIK14/dKUmdUBlCiwqYRY prLyzuDlWXlZLt1htt3YbfCR/3CK6wzgXXiEOcAU= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C38AC60314 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=subashab@codeaurora.org From: Subash Abhinov Kasiviswanathan To: davem@davemloft.net, netdev@vger.kernel.org, lkp@intel.com Cc: Subash Abhinov Kasiviswanathan Subject: [PATCH net-next v2 02/10] net: qualcomm: rmnet: Remove invalid condition while stamping mux id Date: Wed, 3 Jan 2018 14:42:59 -0700 Message-Id: <1515015787-6713-3-git-send-email-subashab@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1515015787-6713-1-git-send-email-subashab@codeaurora.org> References: <1515015787-6713-1-git-send-email-subashab@codeaurora.org> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org rmnet devices cannot have a mux id of 255. This is validated when assigning the mux id to the rmnet devices. As a result, checking for mux id 255 does not apply in egress path. Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c b/drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c index 0553932..b2d317e3 100644 --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c @@ -143,10 +143,7 @@ static int rmnet_map_egress_handler(struct sk_buff *skb, if (!map_header) goto fail; - if (mux_id == 0xff) - map_header->mux_id = 0; - else - map_header->mux_id = mux_id; + map_header->mux_id = mux_id; skb->protocol = htons(ETH_P_MAP);