From patchwork Tue Jan 2 07:28:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Ehrhardt X-Patchwork-Id: 854412 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3z9lzm5Pygz9t3M for ; Tue, 2 Jan 2018 18:28:52 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751910AbeABH2n (ORCPT ); Tue, 2 Jan 2018 02:28:43 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:39807 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751354AbeABH2m (ORCPT ); Tue, 2 Jan 2018 02:28:42 -0500 Received: from 1.general.paelzer.uk.vpn ([10.172.196.172] helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1eWH05-00037j-EB; Tue, 02 Jan 2018 07:28:41 +0000 From: Christian Ehrhardt To: Netdev Cc: Luca Boccassi , Christian Ehrhardt Subject: [PATCH 1/2] tests: read limited amount from /dev/urandom Date: Tue, 2 Jan 2018 08:28:37 +0100 Message-Id: <1514878118-21009-2-git-send-email-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1514878118-21009-1-git-send-email-christian.ehrhardt@canonical.com> References: <1514878118-21009-1-git-send-email-christian.ehrhardt@canonical.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In some test environments like e.g. Ubuntu & Debian autopkgtest it can happen that while generating random device names the pipes between tr and head are considered dead while processing. That prints (non fatal) issues like: Running ip/link/new_link.t [iproute2-this/4.13.0-17-generic]: tr: write error: Broken pipe tr: write error PASS This only happens if reading an infinite amount of chars with the read from urandom, so reading a defined amount fixes the issue. Signed-off-by: Christian Ehrhardt --- testsuite/lib/generic.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testsuite/lib/generic.sh b/testsuite/lib/generic.sh index b7de704..3645ff5 100644 --- a/testsuite/lib/generic.sh +++ b/testsuite/lib/generic.sh @@ -87,7 +87,7 @@ ts_qdisc_available() rand_dev() { - echo "dev-$(tr -dc "[:alpha:]" < /dev/urandom | head -c 6)" + echo "dev-$(head -c 250 /dev/urandom | tr -dc '[:alpha:]' | head -c 6)" } pr_failed()