| Message ID | 1514458864-17640-1-git-send-email-serhe.popovych@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | stephen hemminger |
| Headers | show |
| Series | [iproute2,1/3] vxcan,veth: Forbid "type" for peer device | expand |
On Thu, 28 Dec 2017 13:01:04 +0200 Serhey Popovych <serhe.popovych@gmail.com> wrote: > It is already given for original device we configure this > peer for. > > Results from following command before/after change applied > are shown below: > > $ ip link add dev veth1a type veth peer name veth1b \ > type veth peer name veth1c > > Before: > ------- > > <no output, no netdevs created> > > After: > ------ > > Error: duplicate "type": "veth" is the second value. > > Signed-off-by: Serhey Popovych <serhe.popovych@gmail.com> Applied this one. The other util patches have some issues
diff --git a/ip/iplink_vxcan.c b/ip/iplink_vxcan.c index c13224c..ed0ad8b 100644 --- a/ip/iplink_vxcan.c +++ b/ip/iplink_vxcan.c @@ -65,6 +65,9 @@ static int vxcan_parse_opt(struct link_util *lu, int argc, char **argv, if (err < 0) return err; + if (type) + duparg("type", argv[err]); + if (name) { addattr_l(hdr, 1024, IFLA_IFNAME, name, strlen(name) + 1); diff --git a/ip/link_veth.c b/ip/link_veth.c index fcfd1ef..fddb7ac 100644 --- a/ip/link_veth.c +++ b/ip/link_veth.c @@ -63,6 +63,9 @@ static int veth_parse_opt(struct link_util *lu, int argc, char **argv, if (err < 0) return err; + if (type) + duparg("type", argv[err]); + if (name) { addattr_l(hdr, 1024, IFLA_IFNAME, name, strlen(name) + 1);
It is already given for original device we configure this peer for. Results from following command before/after change applied are shown below: $ ip link add dev veth1a type veth peer name veth1b \ type veth peer name veth1c Before: ------- <no output, no netdevs created> After: ------ Error: duplicate "type": "veth" is the second value. Signed-off-by: Serhey Popovych <serhe.popovych@gmail.com> --- ip/iplink_vxcan.c | 3 +++ ip/link_veth.c | 3 +++ 2 files changed, 6 insertions(+)