From patchwork Fri Dec 22 15:37:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yafang Shao X-Patchwork-Id: 852423 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Wf47f5Ww"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3z3CLg3tFKz9s4s for ; Sat, 23 Dec 2017 02:37:31 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755464AbdLVPhZ (ORCPT ); Fri, 22 Dec 2017 10:37:25 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:45992 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751966AbdLVPhY (ORCPT ); Fri, 22 Dec 2017 10:37:24 -0500 Received: by mail-pf0-f194.google.com with SMTP id u19so15418692pfa.12 for ; Fri, 22 Dec 2017 07:37:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=tU7pa3BFcWtATVMFCAUbTkIG9isjQosWZUp+b4RNH8I=; b=Wf47f5WwC/sikZ9pc7ZzRSParvDs7E3oc1SfrqplDwidy976MIEQ9PonavOf9bvYYy Gayk5ci+/te7fswCkrrAMMgT9y0v9XpVjYv+00OXzPYhGmzkPHImvNOVF9op7rAuzWAm nEHOpBVV6F/AFieZCMUu5EPnJAzFXfi0Yhix5XOTRwlxjfKTO2mg2gxstFusP+qkHNiz iogN+VWetMERvfFD7Kbfw7Rx5uooDDA1wbNgo175BIn8FfGT2W5GyadW+ynvHGWlZZSc ODlEel6Krpx6Guzdt7xFuJYoxebRUzVT0LhwXQcejPSXkMN8bDaNDjX8zPBUGZ7x0va9 UmpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=tU7pa3BFcWtATVMFCAUbTkIG9isjQosWZUp+b4RNH8I=; b=sMfFKC2JthiwmYaTN7fntVrkRlLuxdrE14yVSz0L3avkCldjvhv3lv7wnWGHATtemU a6Mw0QX8knjGlF1g0pITcc71268Aax6pm+RAgAuS06e1e9YZjO4mtB6EoLJ3iFixSHiW lKa2+Hg8huQlxzHzKW9BEv0/XxdIOAVmXRV/G9mbyV/qLbhAeRirxmUKCL0crtNv2pYH HkCAPA39OZSv/pA/lMTYO7N1QyIGN2kS5P84eT3j2TimdFvOfhTY3Bnjb0Lt+J3yfWLi cZotAuSvYi7mNU0EgPgZ3vUrovt7ZRX0l0rGkG2W1bSp21UNCD8S7Y/bLv9mj3gFxNix perw== X-Gm-Message-State: AKGB3mKGWA91TE+C4jwg3YW1QlNlqTE6eeVg8zvllj6rt2Y51RVXFvb+ 9nnfZD+ORcBTONuZ85XEWa6bTCvG X-Google-Smtp-Source: ACJfBos8xt3hYjd7USTzzfbT0JNWPM2OcuywWUGLUq2bBa5zGOab7RJVEPX4RTR1FWEOuj110ZAktQ== X-Received: by 10.98.194.71 with SMTP id l68mr14477378pfg.221.1513957044070; Fri, 22 Dec 2017 07:37:24 -0800 (PST) Received: from li1588-6.members.linode.com (li1588-6.members.linode.com. [139.162.104.6]) by smtp.gmail.com with ESMTPSA id n22sm20204585pgc.76.2017.12.22.07.37.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Dec 2017 07:37:23 -0800 (PST) From: Yafang Shao To: davem@davemloft.net Cc: netdev@vger.kernel.org, Yafang Shao Subject: [PATCH net-next] net/trace: fix printk format in inet_sock_set_state Date: Fri, 22 Dec 2017 23:37:13 +0800 Message-Id: <1513957033-24100-1-git-send-email-laoar.shao@gmail.com> X-Mailer: git-send-email 1.8.3.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org There's a space character missed in the printk messages. This error should be prevented with checkscript.pl, but it couldn't caught by running with "checkscript.pl -f xxxx.patch", that's what I had run before. What a carelessness. Fixes: 563e0bb0dc74("net: tracepoint: replace tcp_set_state tracepoint with inet_sock_set_state tracepoint") Signed-off-by: Yafang Shao --- include/trace/events/sock.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.8.3.1 diff --git a/include/trace/events/sock.h b/include/trace/events/sock.h index 3b9094a..598399da 100644 --- a/include/trace/events/sock.h +++ b/include/trace/events/sock.h @@ -160,7 +160,7 @@ } ), - TP_printk("protocol=%s sport=%hu dport=%hu saddr=%pI4 daddr=%pI4" + TP_printk("protocol=%s sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 " "saddrv6=%pI6c daddrv6=%pI6c oldstate=%s newstate=%s", show_inet_protocol_name(__entry->protocol), __entry->sport, __entry->dport,