From patchwork Tue Dec 12 00:30:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Subash Abhinov Kasiviswanathan X-Patchwork-Id: 847299 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=codeaurora.org header.i=@codeaurora.org header.b="EG7syQKO"; dkim=pass (1024-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="EG7syQKO"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ywgjT0z65z9sBd for ; Tue, 12 Dec 2017 11:31:09 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752456AbdLLAbH (ORCPT ); Mon, 11 Dec 2017 19:31:07 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:35160 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752329AbdLLAau (ORCPT ); Mon, 11 Dec 2017 19:30:50 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id B70D760A19; Tue, 12 Dec 2017 00:30:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1513038649; bh=3Ldhr3yak6zTCe6FeT7McpcWuG++4vnRBqoYg5SSXz4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EG7syQKO4cXPNR9NIjh1MsKe+8CreTac6uuOngtVTQdt5S4X7XxBs4+I15Ziii9G1 imoa2vzk0hohSfRwmgYq/i4EY95+QhnuHwFaq2/HW5VR7sPkemcB0T9CHJQ0NZyMBT YWaBwqHfGjEuBmnc2HxnIugrGSvX55L8Q6hRTtK4= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED, T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from subashab-lnx.qualcomm.com (unknown [129.46.15.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: subashab@codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 089F16055B; Tue, 12 Dec 2017 00:30:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1513038649; bh=3Ldhr3yak6zTCe6FeT7McpcWuG++4vnRBqoYg5SSXz4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EG7syQKO4cXPNR9NIjh1MsKe+8CreTac6uuOngtVTQdt5S4X7XxBs4+I15Ziii9G1 imoa2vzk0hohSfRwmgYq/i4EY95+QhnuHwFaq2/HW5VR7sPkemcB0T9CHJQ0NZyMBT YWaBwqHfGjEuBmnc2HxnIugrGSvX55L8Q6hRTtK4= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 089F16055B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=subashab@codeaurora.org From: Subash Abhinov Kasiviswanathan To: davem@davemloft.net, netdev@vger.kernel.org Cc: Subash Abhinov Kasiviswanathan Subject: [PATCH net-next v3 5/6] net: qualcomm: rmnet: Allow to configure flags for new devices Date: Mon, 11 Dec 2017 17:30:14 -0700 Message-Id: <1513038615-16407-6-git-send-email-subashab@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1513038615-16407-1-git-send-email-subashab@codeaurora.org> References: <1513038615-16407-1-git-send-email-subashab@codeaurora.org> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Add an option to configure the rmnet aggregation and command features on device creation. This is achieved by using the vlan flags option. Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c b/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c index 46bb228..7a4c26e 100644 --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c @@ -177,11 +177,20 @@ static int rmnet_newlink(struct net *src_net, struct net_device *dev, if (err) goto err2; - netdev_dbg(dev, "data format [ingress 0x%08X]\n", ingress_format); - port->ingress_data_format = ingress_format; port->rmnet_mode = mode; hlist_add_head_rcu(&ep->hlnode, &port->muxed_ep[mux_id]); + + if (data[IFLA_VLAN_FLAGS]) { + struct ifla_vlan_flags *flags; + + flags = nla_data(data[IFLA_VLAN_FLAGS]); + ingress_format = flags->flags & flags->mask; + } + + netdev_dbg(dev, "data format [ingress 0x%08X]\n", ingress_format); + port->ingress_data_format = ingress_format; + return 0; err2: @@ -313,7 +322,8 @@ static int rmnet_rtnl_validate(struct nlattr *tb[], struct nlattr *data[], static size_t rmnet_get_size(const struct net_device *dev) { - return nla_total_size(2); /* IFLA_VLAN_ID */ + return nla_total_size(2) /* IFLA_VLAN_ID */ + + nla_total_size(sizeof(struct ifla_vlan_flags)); /* IFLA_VLAN_FLAGS */ } struct rtnl_link_ops rmnet_link_ops __read_mostly = {