| Message ID | 1506614014-4398-2-git-send-email-geert+renesas@glider.be |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | ravb: Add PHY reset support | expand |
Hello! On 09/28/2017 06:53 PM, Geert Uytterhoeven wrote: > The optional "reset-gpios" property (part of the generic MDIO bus > properties) lets us describe the GPIO used for resetting the Ethernet > PHY. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > Documentation/devicetree/bindings/net/renesas,ravb.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt > index c902261893b913f5..4a6ec1ba32d0bf16 100644 > --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt > +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt > @@ -52,6 +52,7 @@ Optional properties: > AVB_LINK signal. > - renesas,ether-link-active-low: boolean, specify when the AVB_LINK signal is > active-low instead of normal active-high. > +- reset-gpios: see mdio.txt in the same directory. Sigh, I can only repeat that was a terrible prop name choice -- when applied to a MAC node... what reset does it mean? MAC? MBR, Sergei
On Thu, Sep 28, 2017 at 11:07:38PM +0300, Sergei Shtylyov wrote: > Hello! > > On 09/28/2017 06:53 PM, Geert Uytterhoeven wrote: > > > The optional "reset-gpios" property (part of the generic MDIO bus > > properties) lets us describe the GPIO used for resetting the Ethernet > > PHY. > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > --- > > Documentation/devicetree/bindings/net/renesas,ravb.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt > > index c902261893b913f5..4a6ec1ba32d0bf16 100644 > > --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt > > +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt > > @@ -52,6 +52,7 @@ Optional properties: > > AVB_LINK signal. > > - renesas,ether-link-active-low: boolean, specify when the AVB_LINK signal is > > active-low instead of normal active-high. > > +- reset-gpios: see mdio.txt in the same directory. > > Sigh, I can only repeat that was a terrible prop name choice -- when > applied to a MAC node... what reset does it mean? MAC? Agreed. This should be in the phy node. Or MDIO at least.
diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt index c902261893b913f5..4a6ec1ba32d0bf16 100644 --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt @@ -52,6 +52,7 @@ Optional properties: AVB_LINK signal. - renesas,ether-link-active-low: boolean, specify when the AVB_LINK signal is active-low instead of normal active-high. +- reset-gpios: see mdio.txt in the same directory. Example: @@ -99,6 +100,7 @@ Example: pinctrl-0 = <ðer_pins>; pinctrl-names = "default"; renesas,no-ether-link; + reset-gpios = <&gpio2 10 GPIO_ACTIVE_LOW>; #address-cells = <1>; #size-cells = <0>;
The optional "reset-gpios" property (part of the generic MDIO bus properties) lets us describe the GPIO used for resetting the Ethernet PHY. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- Documentation/devicetree/bindings/net/renesas,ravb.txt | 2 ++ 1 file changed, 2 insertions(+)