From patchwork Thu Sep 21 12:54:15 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Allen X-Patchwork-Id: 816848 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="OgNkcmnD"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xyc5B63LQz9t4P for ; Thu, 21 Sep 2017 22:54:38 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751636AbdIUMy0 (ORCPT ); Thu, 21 Sep 2017 08:54:26 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:34459 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751387AbdIUMyZ (ORCPT ); Thu, 21 Sep 2017 08:54:25 -0400 Received: by mail-pf0-f196.google.com with SMTP id g65so2465640pfe.1; Thu, 21 Sep 2017 05:54:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=rjXa4ilgrp8j5CqKNwPK/yO2szld5G48Yvi+Iy9Y2GA=; b=OgNkcmnD4sam5EyV8faNX1McKT73VnJB6MRnd02mS01Il35rcPt4+WwGsqC8/OMhHk 9+RDScG0sOdSho4Pazhn1AVrBMsndmOBSAPZVTyAbKF5TNLnpFqHB5fSWPeqHqwXACym 6AdYvUavsvS8DG7tTQHibx7pqZhWxpw52th9wzjznLpr1pf9yIE9PeHQxtK4lt0S/IzO XzsN25x0spnwDMBAro7i4ALwOTagrb9um3hjMYRqot3KUJo9U78wmEiYUQk5/nVANR36 EpRAyAtXHTkLzNx4p2N+BE+NoEIE3urZNHgTGQI9tTUEr1mulYhYVTpswk9yPwjr0B1R Ta5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=rjXa4ilgrp8j5CqKNwPK/yO2szld5G48Yvi+Iy9Y2GA=; b=URlb/+N84a3UPiBhZTA2kdCxTVoCigLDTJsCmaBzAEna39Mmbb+HpgVsViHrU9aS04 GwLmuzzmIN//bTCuwqItSKlT20/HAEc2vg+970rKG0R3Aa1H7fOgQG/Vo0NdViFe3MYY P2h2i9CLYjf1YUEmO5IhJ0TJXpAjbR1PwGwIcDqdac4t7zFSJtq2gs0rt5bzIH5Gdfes t4U33KocNibcamuHKmlySqXqDLGD4PbhIDaAa7udJmst7PzD+ipzX1+Ly5qy435fmG99 6qYMpInYH2zLy9IXi7WcnYwPi/zuQsVnzj1iRNpPIf57zS3Ztp9CgP9Q5FP0m4OBNsjL jhiA== X-Gm-Message-State: AHPjjUgdJQQxeKgyhwXaFfdL1nPqS4ZlLCEt5S7eFclQ60PyWok2QL9m NHldOCRrjzqtjwOupMuaK3SoL6iI X-Google-Smtp-Source: AOwi7QBzH6W0L50xqsy7xH3FGTCaQtYsoE4LtX9mfaGSZkPYvkJwQAtU/qW0AHFYLZRiSm7cTjNVLw== X-Received: by 10.99.133.66 with SMTP id u63mr5801876pgd.426.1505998464156; Thu, 21 Sep 2017 05:54:24 -0700 (PDT) Received: from localhost.localdomain ([103.42.74.194]) by smtp.gmail.com with ESMTPSA id f9sm3108172pfe.150.2017.09.21.05.54.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 21 Sep 2017 05:54:23 -0700 (PDT) From: Allen Pais To: linux-kernel@vger.kernel.org Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, Allen Pais Subject: [PATCH 1/1] net: usb: catc: use setup_timer() helper Date: Thu, 21 Sep 2017 18:24:15 +0530 Message-Id: <1505998455-14776-1-git-send-email-allen.lkml@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Use setup_timer function instead of initializing timer with the function and data fields. Signed-off-by: Allen Pais --- drivers/net/usb/catc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/usb/catc.c b/drivers/net/usb/catc.c index dbc9031..aeb62e1 100644 --- a/drivers/net/usb/catc.c +++ b/drivers/net/usb/catc.c @@ -805,9 +805,7 @@ static int catc_probe(struct usb_interface *intf, const struct usb_device_id *id spin_lock_init(&catc->tx_lock); spin_lock_init(&catc->ctrl_lock); - init_timer(&catc->timer); - catc->timer.data = (long) catc; - catc->timer.function = catc_stats_timer; + setup_timer(&catc->timer, catc_stats_timer, (long)catc); catc->ctrl_urb = usb_alloc_urb(0, GFP_KERNEL); catc->tx_urb = usb_alloc_urb(0, GFP_KERNEL);