| Message ID | 1505993222-16721-1-git-send-email-geert+renesas@glider.be |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: phy: Fix truncation of large IRQ numbers in phy_attached_print() | expand |
On Thu, Sep 21, 2017 at 01:27:02PM +0200, Geert Uytterhoeven wrote: > Given NR_IRQS is 2048 on sparc64, and even 32784 on alpha, 3 digits is > not enough to represent interrupt numbers on all architectures. Hence > PHY interrupt numbers may be truncated during printing. > > Increase the buffer size from 4 to 8 bytes to fix this. > > Fixes: 5e369aefdce4818c ("net: stmmac: Delete dead code for MDIO registration") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
From: Geert Uytterhoeven <geert+renesas@glider.be> Date: Thu, 21 Sep 2017 13:27:02 +0200 > Given NR_IRQS is 2048 on sparc64, and even 32784 on alpha, 3 digits is > not enough to represent interrupt numbers on all architectures. Hence > PHY interrupt numbers may be truncated during printing. > > Increase the buffer size from 4 to 8 bytes to fix this. > > Fixes: 5e369aefdce4818c ("net: stmmac: Delete dead code for MDIO registration") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Applied.
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 8cf0c5901f95870f..67f25ac29025c539 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -879,7 +879,7 @@ void phy_attached_print(struct phy_device *phydev, const char *fmt, ...) { const char *drv_name = phydev->drv ? phydev->drv->name : "unbound"; char *irq_str; - char irq_num[4]; + char irq_num[8]; switch(phydev->irq) { case PHY_POLL:
Given NR_IRQS is 2048 on sparc64, and even 32784 on alpha, 3 digits is not enough to represent interrupt numbers on all architectures. Hence PHY interrupt numbers may be truncated during printing. Increase the buffer size from 4 to 8 bytes to fix this. Fixes: 5e369aefdce4818c ("net: stmmac: Delete dead code for MDIO registration") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/net/phy/phy_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)