From patchwork Sat Sep 16 06:34:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srishti Sharma X-Patchwork-Id: 814476 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="lT+Bb/Kr"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xvMvG4Hvvz9s81 for ; Sat, 16 Sep 2017 16:34:50 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751249AbdIPGeg (ORCPT ); Sat, 16 Sep 2017 02:34:36 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:33846 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750779AbdIPGee (ORCPT ); Sat, 16 Sep 2017 02:34:34 -0400 Received: by mail-pg0-f67.google.com with SMTP id v82so2390986pgb.1; Fri, 15 Sep 2017 23:34:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=CM2ZdDBdB76UCAkE23K1uoSrhBwp++Goba18PRcOCvw=; b=lT+Bb/KrJ1LfiNlQpQVMzbvVjjHbFDpkoxEdGr9yT6/F2gsd2OQ+ek70fgWuJCPbLR DSpz9RxWVeETANutv0+n2emmnkIHlbe01X0Nd4KtefDETEQeVPhPsvh2BCBMW2pQua05 M9gIvDcYlJcvCCD8pAU9Oi1q7BSesMNFKf7oR72Ou9/5PU/G7QC9DYkF0jbzgzSnkfdf cud0l53PpPTmJE4Rily7Jj8dZzbdJmWI8wNh2wXoZZtiXdtmf30RZcQvVDEKM+5E/CVL WwFbSWBH2fxfEx1ExfERwDKTCL9VsV1XUkVJPKoued9A6RkYATkCq6JMWEreqopDdGFV xY5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=CM2ZdDBdB76UCAkE23K1uoSrhBwp++Goba18PRcOCvw=; b=YXZ9g2X15WM/gI2rwjeSStJv4igOuIt1bJIfzpQR365YgzAO0dQRv7Or2tTnq8Lqa1 3s9KDmqZf4fSSMgkFb9OGYkGEz3FCO+ygrlU5J9NEKuWgkT0zlhjc9cuOa12jtKm8mRq jgoVdxUObbzPQmeIbLfwOmzQO9VgzKvvbhWwL7lzI3ElTPAAMcrmlRPLYL0FgdPqBlSX y20x2/6oWvLFC7kFuG6NcnN1N0d+s7XkL2Mtf0oEVQuujWkmYfQgmEtoqOwMHFPdKsuB JvwlGcn0RcwNNWNUjcXzt4+9le/g55OJjyNsINPih70Iiwp85O4dLMlrLhIGoS7/U3+k 3R+A== X-Gm-Message-State: AHPjjUhlRyQP6eX92KigAyC3cIxMzfaYKCvmQMvCcQXZoHos2r0GmTES 3CSyqJG8tO8pPA== X-Google-Smtp-Source: ADKCNb69/qLtNX+9u+sT1Y8Szii3LiBJHvMHKKnivUz+bSYUVib3o78kCqv/XS40HWFSRaiXH1PTeA== X-Received: by 10.101.70.138 with SMTP id h10mr26844436pgr.8.1505543674143; Fri, 15 Sep 2017 23:34:34 -0700 (PDT) Received: from srishti-PRODiiGY-945G ([122.168.202.126]) by smtp.gmail.com with ESMTPSA id i2sm4079131pgq.81.2017.09.15.23.34.32 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 15 Sep 2017 23:34:33 -0700 (PDT) From: Srishti Sharma To: samuel@sortiz.org Cc: gregkh@linuxfoundation.org, netdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com, Srishti Sharma Subject: [PATCH] Staging: irda: Use !x instead of NULL comparison Date: Sat, 16 Sep 2017 12:04:27 +0530 Message-Id: <1505543667-4670-1-git-send-email-srishtishar@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Test for NULL as !x where functions that return NULL on failure are used. Done using the following semantic patch by coccinelle. @ is_null @ expression E; statement S; @@ E = (\(kmalloc\|devm_kzalloc\|kmalloc_array\|devm_ioremap\| usb_alloc_urb\|alloc_netdev\|dev_alloc_skb\)(...)); ( if(!E) S | -if(E==NULL) +if(!E) S ) Signed-off-by: Srishti Sharma Acked-by: Julia Lawall --- drivers/staging/irda/net/discovery.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/irda/net/discovery.c b/drivers/staging/irda/net/discovery.c index 364d70a..1e54954 100644 --- a/drivers/staging/irda/net/discovery.c +++ b/drivers/staging/irda/net/discovery.c @@ -179,7 +179,7 @@ void irlmp_expire_discoveries(hashbin_t *log, __u32 saddr, int force) /* Create the client specific buffer */ n = HASHBIN_GET_SIZE(log); buffer = kmalloc(n * sizeof(struct irda_device_info), GFP_ATOMIC); - if (buffer == NULL) { + if (!buffer) { spin_unlock_irqrestore(&log->hb_spinlock, flags); return; } @@ -291,7 +291,7 @@ struct irda_device_info *irlmp_copy_discoveries(hashbin_t *log, int *pn, /* Create the client specific buffer */ n = HASHBIN_GET_SIZE(log); buffer = kmalloc(n * sizeof(struct irda_device_info), GFP_ATOMIC); - if (buffer == NULL) { + if (!buffer) { spin_unlock_irqrestore(&log->hb_spinlock, flags); return NULL; }