| Message ID | 1503485540-22113-1-git-send-email-arvind.yadav.cs@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Arvind Yadav <arvind.yadav.cs@gmail.com> Date: Wed, 23 Aug 2017 16:22:20 +0530 > genl_ops are not supposed to change at runtime. All functions > working with genl_ops provided by <net/genetlink.h> work with > const genl_ops. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Applied.
diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c index 750949d..e48f0b2 100644 --- a/net/tipc/netlink_compat.c +++ b/net/tipc/netlink_compat.c @@ -1217,7 +1217,7 @@ static int tipc_nl_compat_recv(struct sk_buff *skb, struct genl_info *info) return err; } -static struct genl_ops tipc_genl_compat_ops[] = { +static const struct genl_ops tipc_genl_compat_ops[] = { { .cmd = TIPC_GENL_CMD, .doit = tipc_nl_compat_recv,
genl_ops are not supposed to change at runtime. All functions working with genl_ops provided by <net/genetlink.h> work with const genl_ops. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- Changes in v2: Patch Subject was wrong. changes in v3 : Updated patch subject as per comment. net/tipc/netlink_compat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)