From patchwork Tue Jul 25 11:06:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tonghao Zhang X-Patchwork-Id: 793332 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="WSIkpy8Y"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xGwRn33NPz9s4q for ; Tue, 25 Jul 2017 21:07:01 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751501AbdGYLG6 (ORCPT ); Tue, 25 Jul 2017 07:06:58 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:37570 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750972AbdGYLGz (ORCPT ); Tue, 25 Jul 2017 07:06:55 -0400 Received: by mail-pf0-f195.google.com with SMTP id y25so5307261pfk.4 for ; Tue, 25 Jul 2017 04:06:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=J2oCOfgfDYHVRy2i2lNV06d5ozQRwy7/lRg/PCyuM0M=; b=WSIkpy8YeJ0I8KCq/Xv7W+qTmk218XzrItXE8CWMJk2u0v/OyDHww9i+FpkJkqr9HJ FGxJ95raMJ5qkhXIb0BPk1Pu3FDWdMPkK7ux4WwlW0wiiiB0WNeOaXA9gxbND6cA29Tw vr3oD5ouUE7DSmEaMMigTqede5nLPabUX23J9XRrjloyCdQqZ0s83YLmONXH0QmJQBoP s/YM7metXgo7g/9VCzBRp6Fu7IlZqDSokMCKtIgrQRzYbkFUqLtueLnWU1KN6EzqUZXx aisMxptu4WHfV8zXBuN7kCej/s4XvdgmZb8E2q4xdfizV2QIi7sVNvlGP+foBL1dnk9Y qy9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=J2oCOfgfDYHVRy2i2lNV06d5ozQRwy7/lRg/PCyuM0M=; b=isERp4/eGHCxGscIzk6em8AmAq9bXgkID4Mbo3bitnzCGj3Pz8bwYp6vj/r0yDF3nX 3tJ7iF08XXDGr85YQjiKOgKPO8bqQvy2UKki0BPnhSlmyuV1buCrGVduSbRIX6xJm1tg voFxY5DqJsswBmynBPIN903a6iY+VOPiIIQtxUhTllOzt+aHLxFXmM2niT8hW02yHWeF kjF5lL55QevXHaj0fYAxZLsz02XNq15PDZA0BRhdfr7WE7nEF5BG5WGKFM3cXJ4ND57J AhTJ5GSiPjfvLwJvl1Gj8Hrc1cNS5iO2fuUXDllL2WJkxtppEEjNI/aS5UtsHDoMOmGa 3i3w== X-Gm-Message-State: AIVw110dCNIMXtqbDaBXhNwI03Sbrg3A4ZnvBz6b5aIolkHOFAyEPJAy GDvg+FSqRVplodPd6Gc= X-Received: by 10.84.224.199 with SMTP id k7mr20850703pln.354.1500980815271; Tue, 25 Jul 2017 04:06:55 -0700 (PDT) Received: from local.opencloud.tech.localdomain ([106.120.127.10]) by smtp.gmail.com with ESMTPSA id t199sm8037847pgb.30.2017.07.25.04.06.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Jul 2017 04:06:54 -0700 (PDT) From: Tonghao Zhang To: netdev@vger.kernel.org Cc: Tonghao Zhang Subject: [PATCH 2/3] drivers/net: Compare pointer-typed values to NULL rather than 0. Date: Tue, 25 Jul 2017 04:06:33 -0700 Message-Id: <1500980794-92499-2-git-send-email-xiangxia.m.yue@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1500980794-92499-1-git-send-email-xiangxia.m.yue@gmail.com> References: <1500980794-92499-1-git-send-email-xiangxia.m.yue@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This makes an effort to choose between !x and x == NULL. 1. drivers/net/ethernet/nxp/lpc_eth.c 2. drivers/net/ethernet/amd/declance.c Generated by: scripts/coccinelle/null/badzero.cocci Signed-off-by: Tonghao Zhang --- drivers/net/ethernet/amd/declance.c | 2 +- drivers/net/ethernet/nxp/lpc_eth.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/amd/declance.c b/drivers/net/ethernet/amd/declance.c index 82cc813..76e623b 100644 --- a/drivers/net/ethernet/amd/declance.c +++ b/drivers/net/ethernet/amd/declance.c @@ -606,7 +606,7 @@ static int lance_rx(struct net_device *dev) len = (*rds_ptr(rd, mblength, lp->type) & 0xfff) - 4; skb = netdev_alloc_skb(dev, len + 2); - if (skb == 0) { + if (!skb) { dev->stats.rx_dropped++; *rds_ptr(rd, mblength, lp->type) = 0; *rds_ptr(rd, rmd1, lp->type) = diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c index 08381ef..0d177d4 100644 --- a/drivers/net/ethernet/nxp/lpc_eth.c +++ b/drivers/net/ethernet/nxp/lpc_eth.c @@ -1338,7 +1338,7 @@ static int lpc_eth_drv_probe(struct platform_device *pdev) /* Get size of DMA buffers/descriptors region */ pldat->dma_buff_size = (ENET_TX_DESC + ENET_RX_DESC) * (ENET_MAXF_SIZE + sizeof(struct txrx_desc_t) + sizeof(struct rx_status_t)); - pldat->dma_buff_base_v = 0; + pldat->dma_buff_base_v = NULL; if (use_iram_for_net(&pldat->pdev->dev)) { dma_handle = LPC32XX_IRAM_BASE; @@ -1350,7 +1350,7 @@ static int lpc_eth_drv_probe(struct platform_device *pdev) "IRAM not big enough for net buffers, using SDRAM instead.\n"); } - if (pldat->dma_buff_base_v == 0) { + if (pldat->dma_buff_base_v == NULL) { ret = dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); if (ret) goto err_out_free_irq;