From patchwork Mon May 29 08:24:49 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Mintz, Yuval" X-Patchwork-Id: 768051 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3wbqYv64J5z9s65 for ; Mon, 29 May 2017 18:25:39 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=CAVIUMNETWORKS.onmicrosoft.com header.i=@CAVIUMNETWORKS.onmicrosoft.com header.b="hNxvyuRo"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751387AbdE2IZe (ORCPT ); Mon, 29 May 2017 04:25:34 -0400 Received: from mail-by2nam03on0048.outbound.protection.outlook.com ([104.47.42.48]:5046 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750966AbdE2IZc (ORCPT ); Mon, 29 May 2017 04:25:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=e3mz/CJfFH8RHEpYEFqYgQL+ROkGirISQ3rfOwxCHZ4=; b=hNxvyuRoLDQaaz0FUSoxbtIv/VDONiebPxSivQwdWGxCH5o76FrcfP8LLlFUWSrjXflRn6H6PRXs38r2GnTTadVOzuMCD4F8PFDCUcm6lJ22nSUofZ9u41Fz0qD48WqyPMrG6+pBLZEcZCQu7e8a5+S3rk2njCH8KSUcRzdlV1U= Received: from MWHPR07CA0020.namprd07.prod.outlook.com (2603:10b6:300:dc::30) by CO1PR07MB427.namprd07.prod.outlook.com (2a01:111:e400:103d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1124.9; Mon, 29 May 2017 08:25:15 +0000 Received: from BN1BFFO11FD005.protection.gbl (2a01:111:f400:7c10::1:100) by MWHPR07CA0020.outlook.office365.com (2603:10b6:300:dc::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1124.9 via Frontend Transport; Mon, 29 May 2017 08:25:15 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BN1BFFO11FD005.mail.protection.outlook.com (10.58.144.68) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.1075.5 via Frontend Transport; Mon, 29 May 2017 08:25:14 +0000 Received: from localhost.qlogic.org (10.185.6.94) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Mon, 29 May 2017 01:25:10 -0700 From: Yuval Mintz To: , CC: Yuval Mintz Subject: [PATCH net] qed: Don't log missing periodic stats by default Date: Mon, 29 May 2017 11:24:49 +0300 Message-ID: <1496046289-17330-1-git-send-email-Yuval.Mintz@cavium.com> X-Mailer: git-send-email 1.9.3 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(39840400002)(39450400003)(39410400002)(39400400002)(2980300002)(428002)(189002)(199003)(9170700003)(77096006)(105586002)(36756003)(106466001)(104016004)(6666003)(86362001)(4326008)(5660300001)(53416004)(5003940100001)(107886003)(38730400002)(189998001)(72206003)(47776003)(478600001)(50986999)(356003)(101416001)(305945005)(81166006)(8936002)(50226002)(2906002)(8676002); DIR:OUT; SFP:1101; SCL:1; SRVR:CO1PR07MB427; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; MLV:sfv; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD005; 1:4cTo9nkq9hCats6xl7syjoVovJB80vOO2u4+dZIbdmCIfFIZTDOeiWZs48atYwmaev8rJVmFKAj+j+TkQi61UeBghljCe541q0kpGEhk4PP0Ny24PtQ6O/ETxp0CUGmtWOO4rlsJA85/h2tkMMJG7IVQ0o04Zf5zyShTed9Ed5fs/Zic+52IOoOgLAiYhnfKmt0cYkAh2PG2JCDPnz/PvmUnHNgVmleVKDiaMbjB85Hr10uLys5k0J/Ra3ETU61PrX82Efi33xXkIieSGN/SbTxaKwl8b2hp/0qTtf5Pk/xV+NzLW/L5Fw3bqlvYutZXZQJm0UwU0szcU7bueVgJaLUa45jyIpq0uTxKEgCOTT8UIIEA9T131fVJTee39TU4IkloQdAGTOo2PvBRwS61fjJhPWLDa2fV2Rbhei4sqrlHKZ+3ynN/g3S2rRqJEVyI5U7GwkHxkCV6JAi2Gqr0w5meWZv/Giohfd1vC3uL0UPhOcAGgtvs9I/Hm6fVCQL+ X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR07MB427: X-MS-Office365-Filtering-Correlation-Id: 70714190-cbd7-4740-0c97-08d4a66c3b4c X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(201703131423075)(201703031133081)(201702281549075); SRVR:CO1PR07MB427; X-Microsoft-Exchange-Diagnostics: 1; CO1PR07MB427; 3:QFRuK2hzBKtv0ByuoPRHEhgUvkEKXl/x73ZRpjG62TdemLfFV/zTIkpU0j3UxXxNzou6K4k+qdIJnvBUJ9ST5C2mVpHZUsiDg4vMPc0t7MzpJFhNphLe/esKDQyC80MF4yLoumpyXTSaWGORzAlM7dLt8zX8Rcm5x3TsDYRw0p2pKQ/Vo2/6aCHr8aoTGpO1jcMjZ9uRUtSQe1uP3dcQeKxjIDQjB0StetKB8iSm6w/okcLdcbViS4HvKmDaH5JtvRIWD4FvgKWnL6BnoiKX8dJu4SVvk46hMPL1aKlFYRcv2GaUHHRHsww0iPObAQEPVg4cpfmryegp77teLiDC2hunA2QXjC4bHxKVMaLT/c0DnSda+u3/7IMb/QjRJUVpFthO2HhG+a8PVsh7EjDIdEeY+Cz6Epgjmv9qqxyXiLDGlYLMQr5mOZRryoQN+TH5oQKWnjF/ovcMq0B/syyncj+MhQfcv5UiCGk2Fe72keztiIqzEtWcQBCUT0VC3r3c X-Microsoft-Exchange-Diagnostics: 1; CO1PR07MB427; 25:VuS5DzxCU+qLEGRsR9QsEybiHF6XO6ZQKWPUj+OldyuCxe7VKztE+tv2AiwZWFUklXTZeyHfQ1qcbIzRES0rMVfm1oG+Lz0+W9iGn1Abph2ZvSpv/hh2A1mXxVS520HCZqoXTfujJnBgLNmnV7epBr1qJXOUg51wUa6lDZTHGSsPG0p5z0fVvoiL05oLtywmVao+tB5LwqShANhdiaUyj2O8dU14uSfg7gA0MtKvLHFQMAbyNjpXJbKpDx8Y1eewZIwRbjebQp6a/YwKLDNla5Yq/4yz46WykfbeNUqpionczDvgz6z47D1CvuWAa+l2PJl6Q4I9WWaqa7Mi6QPRiBy/5tZyMoskHfs24RtmVGngHrEVoXPyNEzbyuqoEnlgVbvbcV9Txa0bTpDjL0WqDQhEe0V548Uxh9oomxPIu6s5bk4PxJBl2Pm+cejDWaAlGcjCGV7zloCBH5BNgyyFpUcIlqf65QXHB/htew/M9DU=; 31:HEaAIt8SjEodhp1wwLIXLj6YZ2rckWaLOUJNrr1TNSwHyQ+dWfJS0vum2h15B/BES3hSnh7HrihQp3hQMcA7A+pJROAxsEtTvwsJHai8dTa6MapLQDGTKMHiafkpjqoIT99mHo2IjWe4y9yiZUC83o5lI63XC0I/7CM+ZwSloC1A3bWINnTtuoAtdl+01+WGxaTMgDMHn6gv7R3aNUuHNTu5/j2k/EnatM+2wQ24sjQ7/dMl/sVTI1MEaTv16TuM X-Microsoft-Exchange-Diagnostics: 1; CO1PR07MB427; 20:gABVXVfkrdYoa+YB/O5FzRATn0exrBkgX+o0u+xTPmnJw4Zis6R3vTqvqg0Osaa/aLoBjjuwI22QvFWYXkJK1rOiYMJztclS7DuCQjSK87+uqfLT130MLtgx93Rt91VEdntiC+X7IsX03+4ikxl0ZaxRGEB4LeY0CAVl+6/iqd1Gb935tTzoEqHPG4oLyNz06lJ60OwR21dcPhWhy7U/8PTz8ef5W4s8FaEzXD6BJXPV5NZnWpGrd4bmWq+PrFM8tKmsIrIe2w6rMJxRMWV3zzr8dWWRYqQ6q066jv0oTnqSfVNuJEJD3TmBsG+lL1hfgEr2VUV5G59ou0bBwZ0Gs2zsb+DjOGok+6LxWAXqUiyphhr3aGSHtC49csNEwjfGXS7EWSipf23k4eFYUU1b6TufHwCbzzydSjHNQe+yLGDL6W27CALdpFyW/Uw26MsJVeTIMKd73ST3POZhOXCQyxgrZSRQwjWoxCQrSNqyRMt6wTMeHvSXX+RNSBUv3bEW X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(13016025)(13018025)(10201501046)(3002001)(93006095)(93001095)(6041248)(20161123562025)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123560025)(6072148); SRVR:CO1PR07MB427; BCL:0; PCL:0; RULEID:; SRVR:CO1PR07MB427; X-Microsoft-Exchange-Diagnostics: 1; CO1PR07MB427; 4:XZNJH5jIRDau724OByeElTpMP1hObWU1eE2ahPW0H4JKeEGt4Ep6eWyPe9QhARNushVtpjxLL1wS7DQh6kARrMZE05FtIOoMZMGeE1inIs/gE2C235FRGagMmbgvpU0eUMGSiSfxsduBlDm6Za+BHggk5AGAIRx80w2z38Zd+BAUByLFr0f9QGpU6cQ6jLcmbg9r31eQ3EWN30xgNQ31XGQHjMifxoRf1djjiB+7agwgkYKit7Tnv7uoAuWGqHbfL1MsS2dz13N08e61psIAMBT2A06fJFkCgTGPROT4vanzj2mBeJu1LDYBcnpUhFzhSU7WV9mE2eqdUf1jzvUrUXQThBLSXMsdy5SS4Z0aZFjXpgiCzrtyvpCEpZOvG+O1jy1KvbrXyCCmURQrfj5Dl1TPqlCh4ueiRqV31giqhHQCYnRPeb0pxkC/JV6M39g1c5U/0nAIOHyV56t37ToN5MrEAiNEW/5sftQIZUNNJbLj/D7WgupcuxwuX5Rg8gMW7CO3b6OJdiD6kfyVQHK0MzNqt8frFDnxy+YMIBzhBzzxRwLZ+TviK+yBVcLpmzlfuXk5AZ21+BEuvxo2Kb+KU61h0jEMEFxYb297xbxGCL+ikZQNEhBCCNCJlghiiUuADF1lV63j9UWSmp0wXAWSXNGpzQGzFuRfZQpZL4QIbFN9w6CHL5Van3reqthY9PuKyTjTi9zTTbfDZd5S+XcnS3DHcWzW6crEvjToWqB7H/ZtAc7rS1pFkKk6Hcv2sgZi86+axBOTvjdxA18kxuPbwtIY4njjezwXoZPrmuFWiZo6Jibi61fHypyB1pJ7kHVS X-Forefront-PRVS: 0322B4EDE1 X-Microsoft-Exchange-Diagnostics: 1; CO1PR07MB427; 23:E3YYzNLH4saErvVJYr9v7bl4zjgBw92mp56h1Amh19jAOsqqUlBprXb70GaoW3iksOeKOz+nLyegdjGIMGIm5RTJI40lGvXSa2gDmyz/u48ete1FKjmOKKT8UnTjvOeW06QXHifJugIFMtjHiy9UwsQFd/ao0CSovLSI0SaQr12zczsLmvnTsVBVqtXlc3u2dM68fo+Vyg3zJKpWvVV2vcPMUueBqFNWIIqxUbC7AmqEPMIQuOiA/LMSoSdrseE6mGz2XMgHd1k5zX/bW3o5B/Io1tDhYrx6tyTq0oKRBY1XePZDF7polS9+PcZpwoQDUEBsmumwZPVVEQSJdiccNhKrwKL/Of3Lg10JWjvkuXuaSIrxYMmBIUWXpM1NFwjGxxOEX9gCEP+5h0zA2uaCPgDAutDkWCcJQhE/+mNhQ6mln0MrH5tlQN/bvHqCRzUSo3iyhG29wPHXbg2TolJVbCYRWxJXqk30+OQdU8u7/ZVDbIjnvomA/WtCbB4zcmQTuI1tykTyZjjwLz8WBuzmgYy9Xx2XWWZrxOKTQrTUNE8NpKhlWpH/VhtkHkgRSRoz1ihBAsYB2HuiLaadNuAutkkNj5p6nHFItvMHcMF+J/JIttz1D28+l/FwjlJRtuYwea3rWLjSlKBsfikbbocfIwo+ofZow4d1jOYkK5IaX+YJ8KtMj0yH9zNI2pVZSXn//yTBHS+l6Q2JTV5kc0mj8ClAtLXNw9z3Ov8pF/kpaavxY5D7sOJBxGgZYKshkuWdFo++BNW9aXbXCw8T3YecHVlZQLYVl5GXnta2ktGPcejRirsTeiT86z006fTPo3ulc1slYJEzkrOeiDNeCAkcEuvbQjzKp+2tCVo5gXxdaDHUTxHA59I4rJzjQoTZqgwnm/uKA0//z84IdKfPpP9g2vJlZ2PvnPxq3ScHV8ci3Zw= X-Microsoft-Exchange-Diagnostics: 1; CO1PR07MB427; 6:CYiYzeFKekbWlNFL5i3gDj3CuQUfUHYdmD0D2YCMhSZ4Yx7DItlUUrTmKFox1ERII7Z9PZUSaKdxPVPO06Lz+R3dbfKGzZoNKR9lBM4hjUAxFZMIo6fe5/6GNkPPMyyL9QISR9A78h5zeLDvIkPNr+e4DoWICwVia0xCxQ+ntLA6ex9SYkt1xBIvuKW6tZzSDlw7Ms51BH8Lz9opbpOAkNEXoO8j6AI3RBMjDOESeY0CyBm81OmwZI0JoWVdNYc5xiNPOeAm6uSC4xM5B7edvoDnJoHmNyKclAScsYnMLrNccKrCKWHrf+WGd89afLXlGPsTVwEKSOCZbYCixLY7Lo4yqxI44QPydE4jbuchE8i1efLgLv1ieRg1L2BUZj86UjaNnTT3mSwjKienKyZryTILOstrTXGVS1Zm46oIeAS2rDdw9jNoI6JN0pvRfEVtpeuLJ5R8huUDzNHJNEvi4PI18xkQof46c13Sqr67Laq7KWDsduMtv0ImvhaQyp86cBxXAw0OlX69Gx590Voiyg==; 5:Tu0vHiAMSBnvwEG05htAJmiNi/HNMC7nzH3UXkOZOlBr5m6u0eSBpTLYbo1SyrqM/A8CcwwGRmjCyX48hAqTiHPuIbQfhrZycCD8jof1zLtvT7cbW3NtMLQTTvR7S9AaQKBoPZFM3sWkPwRikmkg6KVd7d2SWradGg7R+BwjxN4=; 24:Q8EYcm0BvdKDtZMIgPTdXJnMQFjJBqr6GL7F/iT7AEQ/ciu37MsL9M9ckyISTGF0Wq2dIWNzgeUdAU3z1DJWHakFKY5PaN2MRxj6ROE9JSk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CO1PR07MB427; 7:oMUqz7m/xBDonTjk5DOUh4vI7zZBGiZllm3ieTijbO5WJezOdTDZ4YM99ZgBpdF5f+4HVRd88TVL/4XVxbM2P88zCZc7bVFeaEHYM1TylPNKNu0Y6dRsy2j5vU1+2hsigkifAQM8foXbt/5ins+4Luowclmz+MFFQY4p4hoH3Ey0ApPtzJG850fodZmQibODDAXUae+fHa2q2GNfiAuwwyMVM7wy+E6ANxCZJNtObEnR585haX7hrKjmovxpJBnWrU+n/yK/16ug9orSF+z3rsNQDgVNuP/gdLcuoP07PxGahnikNtlXePCNDeK+Z7Pwuml9pwgrQAx/8JxJ/Hel8Q== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2017 08:25:14.4013 (UTC) X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR07MB427 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Current implementation lacks the logic for providing management firmware with RDMA-related statistics; [much] worse than that - it logs such events by default to system logs. Since the statistics' gathering is done periodically, using sufficiently new management firmware the system logs would get filled with these unnecessary prints. For now, reduce the verbosity of the log so that it would not be logged by default. Fixes: 6c75424612a7 ("qed: Add support for NCSI statistics") Signed-off-by: Yuval Mintz --- Hi Dave, Please consider applying this to `net'. Thanks, Yuval --- drivers/net/ethernet/qlogic/qed/qed_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c b/drivers/net/ethernet/qlogic/qed/qed_main.c index 537d123..715b3aa 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_main.c +++ b/drivers/net/ethernet/qlogic/qed/qed_main.c @@ -1730,7 +1730,8 @@ void qed_get_protocol_stats(struct qed_dev *cdev, qed_get_protocol_stats_iscsi(cdev, &stats->iscsi_stats); break; default: - DP_ERR(cdev, "Invalid protocol type = %d\n", type); + DP_VERBOSE(cdev, QED_MSG_SP, + "Invalid protocol type = %d\n", type); return; } }