| Message ID | 1495114265-23368-4-git-send-email-vyasevic@redhat.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On Thu, May 18, 2017 at 09:31:05AM -0400, Vladislav Yasevich wrote: > Since virtio does not provide it's own ndo_features_check handler, > TSO, and now checksum offload, are disabled for stacked vlans. > Re-enable the support and let the host take care of it. This > restores/improves Guest-to-Guest performance over Q-in-Q vlans. > > CC: "Michael S. Tsirkin" <mst@redhat.com> > CC: Jason Wang <jasowang@redhat.com> > CC: virtualization@lists.linux-foundation.org > Signed-off-by: Vladislav Yasevich <vyasevic@redhat.com> Acked-by: Michael S. Tsirkin <mst@redhat.com> > --- > drivers/net/virtio_net.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index 8324a5e..341fb96 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -2028,6 +2028,7 @@ static const struct net_device_ops virtnet_netdev = { > .ndo_poll_controller = virtnet_netpoll, > #endif > .ndo_xdp = virtnet_xdp, > + .ndo_features_check = passthru_features_check, > }; > > static void virtnet_config_changed_work(struct work_struct *work) > -- > 2.7.4
On 2017年05月18日 21:31, Vladislav Yasevich wrote: > Since virtio does not provide it's own ndo_features_check handler, > TSO, and now checksum offload, are disabled for stacked vlans. > Re-enable the support and let the host take care of it. This > restores/improves Guest-to-Guest performance over Q-in-Q vlans. > > CC: "Michael S. Tsirkin" <mst@redhat.com> > CC: Jason Wang <jasowang@redhat.com> > CC: virtualization@lists.linux-foundation.org > Signed-off-by: Vladislav Yasevich <vyasevic@redhat.com> > --- > drivers/net/virtio_net.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index 8324a5e..341fb96 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -2028,6 +2028,7 @@ static const struct net_device_ops virtnet_netdev = { > .ndo_poll_controller = virtnet_netpoll, > #endif > .ndo_xdp = virtnet_xdp, > + .ndo_features_check = passthru_features_check, > }; > > static void virtnet_config_changed_work(struct work_struct *work) Acked-by: Jason Wang <jasowang@redhat.com>
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 8324a5e..341fb96 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -2028,6 +2028,7 @@ static const struct net_device_ops virtnet_netdev = { .ndo_poll_controller = virtnet_netpoll, #endif .ndo_xdp = virtnet_xdp, + .ndo_features_check = passthru_features_check, }; static void virtnet_config_changed_work(struct work_struct *work)
Since virtio does not provide it's own ndo_features_check handler, TSO, and now checksum offload, are disabled for stacked vlans. Re-enable the support and let the host take care of it. This restores/improves Guest-to-Guest performance over Q-in-Q vlans. CC: "Michael S. Tsirkin" <mst@redhat.com> CC: Jason Wang <jasowang@redhat.com> CC: virtualization@lists.linux-foundation.org Signed-off-by: Vladislav Yasevich <vyasevic@redhat.com> --- drivers/net/virtio_net.c | 1 + 1 file changed, 1 insertion(+)