From patchwork Thu Apr 13 18:38:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cong Wang X-Patchwork-Id: 750559 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3w3qL45xLPz9sN5 for ; Fri, 14 Apr 2017 04:38:20 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ZaBh86+p"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755362AbdDMSiS (ORCPT ); Thu, 13 Apr 2017 14:38:18 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:35221 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752273AbdDMSiQ (ORCPT ); Thu, 13 Apr 2017 14:38:16 -0400 Received: by mail-pf0-f194.google.com with SMTP id a188so12188701pfa.2 for ; Thu, 13 Apr 2017 11:38:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=jfC3ogs0vF7zjlDBvzoLZX7ceRc/ZK+7nxDbkGayPJY=; b=ZaBh86+pWKYxApn7Iafo4ugeHC8VVcQB7Jx6HfaZoS0dpth8BQ6GmYwHoDt2SmteMm pKVFAJCJM5741AlMRhdQxQqfPuv6hDYLKUI1i5YYcHzlQ37pFjYLGjxFhnPtiilvVdug ejt8nXmtns6KhrGQPcOv8xp5bQPn/GS2fK/ioM5w7eA2kOf9vgHmMAL2z0DTzUIozByx uEs1QERksaPd879huVnsSwtuuKM+tU3TJ9r/O13OHt2668UqlrJGbVX0U8GfKwT/8KGd oZcZbmpnm3JkI5vaRUYDgLrS9aPSs9ksg0r6F+IHRnme4GFLWq6PYrC4sfDNvF6Gs1gF dSfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=jfC3ogs0vF7zjlDBvzoLZX7ceRc/ZK+7nxDbkGayPJY=; b=A1YyPPKiXz0FsyTivajTjPJgXLJiyqHxfiyPaPq8YnDm2ef4I9EsKokLsIGU6cBNas W9kWRY8aVHU7Jzq87xwTNuyfE/EdoTfopB+iP3mfbDCYUgxsJF1NiFXKcv8qF6O0FfU9 nf5scg/9NKV3M7Q9i8CRZKBz6S6+tIIB2DYTswfMZxnnfzUYOAW45hrEwVzthyGhZDgF 8xM1fu3ouCDZLClOeW145bjK3QeR3XnQpKRAPKenQ51WU5AgAPP9lBa2O0U9Gl1d51a9 +bLR6ykKRX5d9pFHbz8Toj4yx1uoZOYHvWc0zQTuKyDt0xKBFo/GTR1iVWl0SFk1DkPH rbOA== X-Gm-Message-State: AN3rC/6pm1ACowGjsd+3Ye/HVJu6iyhICT/HQMPd8Hc72xMlsgW+Etjx bXn3cCFSVwV/9Q== X-Received: by 10.98.214.6 with SMTP id r6mr4053258pfg.181.1492108695851; Thu, 13 Apr 2017 11:38:15 -0700 (PDT) Received: from tw-172-25-29-91.office.twttr.net ([8.25.197.27]) by smtp.gmail.com with ESMTPSA id s11sm43938385pgc.61.2017.04.13.11.38.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Apr 2017 11:38:14 -0700 (PDT) From: Cong Wang To: netdev@vger.kernel.org Cc: Cong Wang , Tom Herbert Subject: [Patch net-next] kcm: remove a useless copy_from_user() Date: Thu, 13 Apr 2017 11:38:02 -0700 Message-Id: <1492108682-30505-1-git-send-email-xiyou.wangcong@gmail.com> X-Mailer: git-send-email 2.5.5 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org struct kcm_clone only contains fd, and kcm_clone() only writes this struct, so there is no need to copy it from user. Cc: Tom Herbert Signed-off-by: Cong Wang --- net/kcm/kcmsock.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/net/kcm/kcmsock.c b/net/kcm/kcmsock.c index 31762f7..deca20f 100644 --- a/net/kcm/kcmsock.c +++ b/net/kcm/kcmsock.c @@ -1707,11 +1707,7 @@ static int kcm_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg) struct kcm_clone info; struct socket *newsock = NULL; - if (copy_from_user(&info, (void __user *)arg, sizeof(info))) - return -EFAULT; - err = kcm_clone(sock, &info, &newsock); - if (!err) { if (copy_to_user((void __user *)arg, &info, sizeof(info))) {