From patchwork Fri Apr 7 21:25:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Ahern X-Patchwork-Id: 748466 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3w0CLQ0RRMz9s7t for ; Sat, 8 Apr 2017 07:26:06 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=cumulusnetworks.com header.i=@cumulusnetworks.com header.b="T90irvv+"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933829AbdDGVZy (ORCPT ); Fri, 7 Apr 2017 17:25:54 -0400 Received: from mail-pg0-f45.google.com ([74.125.83.45]:33047 "EHLO mail-pg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751174AbdDGVZq (ORCPT ); Fri, 7 Apr 2017 17:25:46 -0400 Received: by mail-pg0-f45.google.com with SMTP id x125so77210442pgb.0 for ; Fri, 07 Apr 2017 14:25:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=40PTYLj8pw6R9jWcG0YouHgy9oCITmHmDzXc4XTb4fE=; b=T90irvv+HJvNUxL/tIy1KySoj9OFy9UsdnW2AGTirLJT4/bDWINcuiSCeFY45eDs2m sg123ndGLdgFi0rJmlUXnWAw9+wPaZoV7agkTFd7v8g0u+MHsJqqlFFyzpKJF+hkph3G FKFN5Va/riprB9dXoabjptqXhjTZr+jUAwlGs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=40PTYLj8pw6R9jWcG0YouHgy9oCITmHmDzXc4XTb4fE=; b=COIdxDBaSwP21EjppdWBsMUowz7S9pNmL0z/RnHBtErF3K+GKvASkArXtdZXs+PKWX RF/fIdBbclf8nLgnw2Cj119DY4csrIVDwdUiJ7CjcqBpZuAmDgtMWQ78ZII9CYitiidZ dd+ZcrrN9vNRcZ8wmkJnL4gOr5kMOqAdloJpsOUbaLjKMTzkTI5JRkQh0tvMn4T523Hx MGUSP8ePSmGj94vunRPQFPXLUxB3q3ZGPyJvWgPT2n/HwSND751yPMd9SmmSiMjdmX4P uvTgn6N06C/cqhFiATtjVumYPpJjvC/svvT+59DYJivu5iDGB4K6rpb5nUnKePjzNQun Gwgg== X-Gm-Message-State: AFeK/H1M5fUIJgGhsjSC9FTaH7OlGVEj8F4rVF94AaYExtdIXQa9O99kFcEjiilrD1tkRL8o X-Received: by 10.84.218.68 with SMTP id f4mr52264360plm.146.1491600346083; Fri, 07 Apr 2017 14:25:46 -0700 (PDT) Received: from kenny.it.cumulusnetworks.com. ([216.129.126.126]) by smtp.googlemail.com with ESMTPSA id t15sm11274422pfl.25.2017.04.07.14.25.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 07 Apr 2017 14:25:45 -0700 (PDT) From: David Ahern To: netdev@vger.kernel.org Cc: vyasevic@redhat.com, davem@davemloft.net, David Ahern Subject: [PATCH net-next 1/8] rtnetlink: Do not generate notifications for MTU events Date: Fri, 7 Apr 2017 14:25:33 -0700 Message-Id: <1491600340-8359-2-git-send-email-dsa@cumulusnetworks.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1491600340-8359-1-git-send-email-dsa@cumulusnetworks.com> References: <1491600340-8359-1-git-send-email-dsa@cumulusnetworks.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Changing MTU on a link currently causes 3 messages to be sent to userspace: [LINK]11: dummy1: mtu 1490 qdisc noqueue state UNKNOWN group default event PRE_CHANGE_MTU link/ether f2:52:5c:6d:21:f3 brd ff:ff:ff:ff:ff:ff [LINK]11: dummy1: mtu 1500 qdisc noqueue state UNKNOWN group default event CHANGE_MTU link/ether f2:52:5c:6d:21:f3 brd ff:ff:ff:ff:ff:ff [LINK]11: dummy1: mtu 1500 qdisc noqueue state UNKNOWN group default link/ether f2:52:5c:6d:21:f3 brd ff:ff:ff:ff:ff:ff Remove the PRE_CHANGE_MTU and CHANGE_MTU messages. Signed-off-by: David Ahern --- include/uapi/linux/if_link.h | 2 -- net/core/rtnetlink.c | 8 -------- 2 files changed, 10 deletions(-) diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h index 97f6d302f627..e8b7e9342cc0 100644 --- a/include/uapi/linux/if_link.h +++ b/include/uapi/linux/if_link.h @@ -903,7 +903,6 @@ enum { enum { IFLA_EVENT_UNSPEC, IFLA_EVENT_REBOOT, - IFLA_EVENT_CHANGE_MTU, IFLA_EVENT_CHANGE_ADDR, IFLA_EVENT_CHANGE_NAME, IFLA_EVENT_FEAT_CHANGE, @@ -912,7 +911,6 @@ enum { IFLA_EVENT_NOTIFY_PEERS, IFLA_EVENT_CHANGE_UPPER, IFLA_EVENT_RESEND_IGMP, - IFLA_EVENT_PRE_CHANGE_MTU, IFLA_EVENT_CHANGE_INFO_DATA, IFLA_EVENT_PRE_CHANGE_UPPER, IFLA_EVENT_CHANGE_LOWER_STATE, diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index b2bd4c9ee860..72d365ae14b3 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -1285,9 +1285,6 @@ static int rtnl_fill_link_event(struct sk_buff *skb, unsigned long event) case NETDEV_REBOOT: rtnl_event = IFLA_EVENT_REBOOT; break; - case NETDEV_CHANGEMTU: - rtnl_event = IFLA_EVENT_CHANGE_MTU; - break; case NETDEV_CHANGEADDR: rtnl_event = IFLA_EVENT_CHANGE_ADDR; break; @@ -1312,9 +1309,6 @@ static int rtnl_fill_link_event(struct sk_buff *skb, unsigned long event) case NETDEV_RESEND_IGMP: rtnl_event = IFLA_EVENT_RESEND_IGMP; break; - case NETDEV_PRECHANGEMTU: - rtnl_event = IFLA_EVENT_PRE_CHANGE_MTU; - break; case NETDEV_CHANGEINFODATA: rtnl_event = IFLA_EVENT_CHANGE_INFO_DATA; break; @@ -4191,7 +4185,6 @@ static int rtnetlink_event(struct notifier_block *this, unsigned long event, voi switch (event) { case NETDEV_REBOOT: - case NETDEV_CHANGEMTU: case NETDEV_CHANGEADDR: case NETDEV_CHANGENAME: case NETDEV_FEAT_CHANGE: @@ -4200,7 +4193,6 @@ static int rtnetlink_event(struct notifier_block *this, unsigned long event, voi case NETDEV_NOTIFY_PEERS: case NETDEV_CHANGEUPPER: case NETDEV_RESEND_IGMP: - case NETDEV_PRECHANGEMTU: case NETDEV_CHANGEINFODATA: case NETDEV_PRECHANGEUPPER: case NETDEV_CHANGELOWERSTATE: