From patchwork Fri Mar 17 21:54:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philippe Reynes X-Patchwork-Id: 740539 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3vlJz34RDRz9ryj for ; Sat, 18 Mar 2017 08:54:39 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="VpKetOo8"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751293AbdCQVyP (ORCPT ); Fri, 17 Mar 2017 17:54:15 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:32846 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751098AbdCQVyN (ORCPT ); Fri, 17 Mar 2017 17:54:13 -0400 Received: by mail-wr0-f196.google.com with SMTP id g10so11018897wrg.0; Fri, 17 Mar 2017 14:54:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=L/wEmEx/p7fqghS6Xp7rbWloxm6ofAENQMv6rEpwnmY=; b=VpKetOo8a+b+iqFJcm33e6FSf43Wcmdj1pRui7It8El+QLFwEMyO5lE0MiaNjNxLUQ cnElqPjgveRnAxIN9Fz917smDHhJQ93YzG2zNSVGk93eW6BYvqr2CwZ5RmmHKlwv+Qpw l5mHwrYzbaCRIQWLV+GCfyBzrQcOWHXG/PpJcjACis2Wb3UlpHh+e65q4ZYtI5regro8 bWqVP0S3OyrJl2IoSY8QvB+d1a/IhCrbIQCbFjngXl0Obn8Ldwyslso+10JIKMykL12n w0flM6qI0DitdbArEhm/JMxPF7QM8giREK5IhPZt1etdVdC2dNfsYp3aewt7QULBgA3n 1kuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=L/wEmEx/p7fqghS6Xp7rbWloxm6ofAENQMv6rEpwnmY=; b=QK2U+cVsqAANGaSdTmeRhPGbkl/NJ8SnuCJj8fidm7SkJV6wsxpMqnx76ujcV13Vse I4EiuvMr0i1SoMITSX07eMItDqvgnnwiJZV3h9IIo4Jv1rsi8K/DM312agfp7eK1IYDT JAqdZIOOWCEZxN3rZto/U77EEPcPnAuleyhkJKzvA+kKFA02g1SLCly2VXWHCfKqgMzU cW2i+qPWUzDLPGNhRtDKBzlCFZ8dq2QjqwPAbvOk31kN518x2Nl1j3NEKINYc8cGhI27 c4UTsR3E/lgDwcZCqsuYNuJtQKTU3G6niCd5WOlpSMoUUd75g6T562ts/7d/DxR2Rbbv TZ6Q== X-Gm-Message-State: AFeK/H2jGZ0aOOKEZg1YXjMjbG+7QmDBVh2/BdyGsy/EvvoyrDv30dZZMjBHtwgUKoGuhg== X-Received: by 10.223.176.20 with SMTP id f20mr15144314wra.160.1489787651074; Fri, 17 Mar 2017 14:54:11 -0700 (PDT) Received: from localhost.localdomain (bny93-7-88-161-33-221.fbx.proxad.net. [88.161.33.221]) by smtp.gmail.com with ESMTPSA id j26sm11302975wrb.69.2017.03.17.14.54.09 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 17 Mar 2017 14:54:10 -0700 (PDT) From: Philippe Reynes To: davem@davemloft.net, mugunthanvnm@ti.com, jarod@redhat.com, felipe.balbi@linux.intel.com, edumazet@google.com, fw@strlen.de Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Philippe Reynes Subject: [PATCH v3] net: sun: sungem: rix a possible null dereference Date: Fri, 17 Mar 2017 22:54:04 +0100 Message-Id: <1489787644-28822-1-git-send-email-tremyfr@gmail.com> X-Mailer: git-send-email 1.7.4.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The function gem_begin_auto_negotiation dereference the pointer ep before testing if it's null. This patch add a check on ep before dereferencing it. Fixes: 92552fdda557 ("net: sun: sungem: use new api ethtool_{get|set}_link_ksettings") Reported-by: Dan Carpenter Signed-off-by: Philippe Reynes --- Changelog: v3: - fix the sha1-id in the tag Fixes (thanks David Miller) v2: - use Fixes tag (thanks Sergei Shtylyov) drivers/net/ethernet/sun/sungem.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/sun/sungem.c b/drivers/net/ethernet/sun/sungem.c index dbfca04..fa607d0 100644 --- a/drivers/net/ethernet/sun/sungem.c +++ b/drivers/net/ethernet/sun/sungem.c @@ -1259,8 +1259,9 @@ static void gem_begin_auto_negotiation(struct gem *gp, int duplex; u32 advertising; - ethtool_convert_link_mode_to_legacy_u32(&advertising, - ep->link_modes.advertising); + if (ep) + ethtool_convert_link_mode_to_legacy_u32( + &advertising, ep->link_modes.advertising); if (gp->phy_type != phy_mii_mdio0 && gp->phy_type != phy_mii_mdio1)