From patchwork Wed Mar 15 21:51:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philippe Reynes X-Patchwork-Id: 739451 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3vk51w1SBsz9ryr for ; Thu, 16 Mar 2017 08:52:52 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="iH5aw8wz"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754169AbdCOVve (ORCPT ); Wed, 15 Mar 2017 17:51:34 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:33108 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751495AbdCOVvb (ORCPT ); Wed, 15 Mar 2017 17:51:31 -0400 Received: by mail-wr0-f194.google.com with SMTP id g10so3651092wrg.0; Wed, 15 Mar 2017 14:51:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=k/S8yPh3JjCplbD21JKTdfh0oYudS9Noz9936RNY0yk=; b=iH5aw8wzWKy2GQgjCY6otY7r/sdPoijl1rPY1XXo288dP6i0JSrG8IKoSNxpTLeGWT 32xtTFRirgWOHC3mbp+hWk2ikjEOsH9xYG7YmjZbQ+P7y+eUuZ3TnbB0IZnnM9JynVva 8u6TWSdVe5sHFlXP1VMoZnl6Ve/kVXwOpTHnvQkGRr32L4yxk1CXMJPCgTJDvV52tlu+ jUSqTqxYEJ/0G4eqKz+dg+eDOfgcvfjcuntdI/s7L2BecQyNoiGGvHbabJ8mepfx6w9m 8GHcQhR9x8nyd5gajNPjqGhi8ODPDxWYdeZ9F7wR99cXpzb8ez4hi4yA5ygYqJAxigBS +NFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=k/S8yPh3JjCplbD21JKTdfh0oYudS9Noz9936RNY0yk=; b=YzBJL81O4h+Vi5VS5VCB/fufcrn7Q8rTU1Aiy2Q0xDGsNKq5mt/VM5D+Q3Iq7PA/bK 678dWuuxAXCMesaKt3O8FjCcpPCcqBui9Mj3ssNKP1ZP4PMlzwCj+Vho6TPlq89DAdUp et39/NcuZAM1UYtpMKpXqkomx1C5oEbyOgoP7veHlyDS7k8+geg/+mgSUkXvjxkj/BNb 0HREkHufhf4aTL99AJnKqavz4htI9JErk9vpJaU8/MqCH5cUItZtagdoviJnYKJH3OEL qwexDtRth4mqOs/DwR8pnGmtEiIWS2j1O7YJKwWHFLdFDm4WPAcIyJXn4VLNnwZBFjqc zuhg== X-Gm-Message-State: AFeK/H3va9IdTeL5zoGqzip58JTWGV3jMHSLzvL9gYaLDe0lQi2MOXGqQb98LvotBDbCzg== X-Received: by 10.223.138.139 with SMTP id y11mr4550631wry.190.1489614688945; Wed, 15 Mar 2017 14:51:28 -0700 (PDT) Received: from localhost.localdomain (bny93-7-88-161-33-221.fbx.proxad.net. [88.161.33.221]) by smtp.gmail.com with ESMTPSA id m83sm1890634wmc.33.2017.03.15.14.51.27 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 15 Mar 2017 14:51:28 -0700 (PDT) From: Philippe Reynes To: davem@davemloft.net, mugunthanvnm@ti.com, jarod@redhat.com, felipe.balbi@linux.intel.com, edumazet@google.com, fw@strlen.de, sergei.shtylyov@cogentembedded.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Philippe Reynes Subject: [PATCH v2] net: sun: sungem: rix a possible null dereference Date: Wed, 15 Mar 2017 22:51:13 +0100 Message-Id: <1489614673-12595-1-git-send-email-tremyfr@gmail.com> X-Mailer: git-send-email 1.7.4.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The function gem_begin_auto_negotiation dereference the pointer ep before testing if it's null. This patch add a check on ep before dereferencing it. Fixes: 92552fdd557 ("net: sun: sungem: use new api ethtool_{get|set}_link_ksettings") Reported-by: Dan Carpenter Signed-off-by: Philippe Reynes --- Chanelog: v2: - use Fixes tag (thanks Sergei Shtylyov) drivers/net/ethernet/sun/sungem.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/sun/sungem.c b/drivers/net/ethernet/sun/sungem.c index dbfca04..fa607d0 100644 --- a/drivers/net/ethernet/sun/sungem.c +++ b/drivers/net/ethernet/sun/sungem.c @@ -1259,8 +1259,9 @@ static void gem_begin_auto_negotiation(struct gem *gp, int duplex; u32 advertising; - ethtool_convert_link_mode_to_legacy_u32(&advertising, - ep->link_modes.advertising); + if (ep) + ethtool_convert_link_mode_to_legacy_u32( + &advertising, ep->link_modes.advertising); if (gp->phy_type != phy_mii_mdio0 && gp->phy_type != phy_mii_mdio1)