From patchwork Tue Mar 14 21:23:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philippe Reynes X-Patchwork-Id: 738940 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3vjSQx5Jzlz9s1h for ; Wed, 15 Mar 2017 08:23:53 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="erJDcsZU"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753153AbdCNVXl (ORCPT ); Tue, 14 Mar 2017 17:23:41 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:34207 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751872AbdCNVXi (ORCPT ); Tue, 14 Mar 2017 17:23:38 -0400 Received: by mail-wm0-f65.google.com with SMTP id u132so1846953wmg.1; Tue, 14 Mar 2017 14:23:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=chNommVEBUutR1JXwsiPu0AqVVhQOgmzXwJah/KgzJk=; b=erJDcsZU0/T/utwMK5gLwsMeUYFRXtkKAC7FQm84+QAFCjg43m2YDb538FtP/1r91M 0HE3s14DXgJPbsW3NXCSnFJLp2DOU14S1aGUGo/SrrN7QRw+bWjPolRuXSeW7wueD4fz aQtl6/lEV1yeFmfw8iiK1gGpXBdYPJenaAuDA4Cn2Kxsl6o83yygVNyEK1KEq9Cwp7mR 0W1RvzlsPBXCq4PW96SHJwz+FM4obqQhOsEIUF/HAyRjSGZKqFMaLFhRqY36clxEb4gH lma+SCFbXles1Sxky4WsoE07p6kHm7KE+mhdLmqvrs2IHjNuaNRv3AJRtlwMHnU8Cf97 j7SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=chNommVEBUutR1JXwsiPu0AqVVhQOgmzXwJah/KgzJk=; b=gJG0KHuZ7NJUXGsEKmHguHSG1Cad3gbT8hwNXMvcgX27vUcvam3hx+Tk0BVVX8KALd HaIBHUjepeNqIp/+6a/42iFiPQQOo5PcOa11Ek/qP2mn3YSX/SgkxrjybTIwQPz7fmVm juECWNjfPv27OgxtAsZ/EvdFn6PXK4DlsD43Z7ePfFCsLZghuV6x8kzm0EhNUEbMeKUR nDUyPWZajqywunUfB2Aa/pnURGAtL2SZQGD6JNLd4Vu9+rRTVw2sQW7nu7pDvMk/4QBU dx9Oe0b5U/sPQ477lz2cci13KbS9jQbSle0VbWhpdsDeQ0vwXd9FKcU6Fym3zCmZkxrk BC1w== X-Gm-Message-State: AFeK/H0TUCfoQiBz6FqLAckRaaSJI2wRxK24QCCiawPXfK0KlEICbznRVIlKtzei5y3e6g== X-Received: by 10.28.183.4 with SMTP id h4mr17770220wmf.140.1489526616956; Tue, 14 Mar 2017 14:23:36 -0700 (PDT) Received: from localhost.localdomain (bny93-7-88-161-33-221.fbx.proxad.net. [88.161.33.221]) by smtp.gmail.com with ESMTPSA id 63sm1267048wmp.9.2017.03.14.14.23.35 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 14 Mar 2017 14:23:36 -0700 (PDT) From: Philippe Reynes To: davem@davemloft.net, mugunthanvnm@ti.com, jarod@redhat.com, felipe.balbi@linux.intel.com, edumazet@google.com, fw@strlen.de, dan.carpenter@oracle.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Philippe Reynes Subject: [PATCH] net: sun: sungem: rix a possible null dereference Date: Tue, 14 Mar 2017 22:23:21 +0100 Message-Id: <1489526601-9423-1-git-send-email-tremyfr@gmail.com> X-Mailer: git-send-email 1.7.4.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The function gem_begin_auto_negotiation dereference the pointer ep before testing if it's null. This patch add a check on ep before dereferencing it. This issue was added by the patch 92552fdd557: "net: sun: sungem: use new api ethtool_{get|set}_link_ksettings". Reported-by: Dan Carpenter Signed-off-by: Philippe Reynes --- drivers/net/ethernet/sun/sungem.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/sun/sungem.c b/drivers/net/ethernet/sun/sungem.c index dbfca04..fa607d0 100644 --- a/drivers/net/ethernet/sun/sungem.c +++ b/drivers/net/ethernet/sun/sungem.c @@ -1259,8 +1259,9 @@ static void gem_begin_auto_negotiation(struct gem *gp, int duplex; u32 advertising; - ethtool_convert_link_mode_to_legacy_u32(&advertising, - ep->link_modes.advertising); + if (ep) + ethtool_convert_link_mode_to_legacy_u32( + &advertising, ep->link_modes.advertising); if (gp->phy_type != phy_mii_mdio0 && gp->phy_type != phy_mii_mdio1)