From patchwork Tue Mar 14 01:38:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qiang Zhao X-Patchwork-Id: 738517 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3vhyRh5wZtz9s78 for ; Tue, 14 Mar 2017 12:52:48 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752923AbdCNBwq (ORCPT ); Mon, 13 Mar 2017 21:52:46 -0400 Received: from mail-sn1nam02on0089.outbound.protection.outlook.com ([104.47.36.89]:4881 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752689AbdCNBwo (ORCPT ); Mon, 13 Mar 2017 21:52:44 -0400 Received: from BN6PR03CA0061.namprd03.prod.outlook.com (10.173.137.23) by BLUPR03MB184.namprd03.prod.outlook.com (10.255.212.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.961.17; Tue, 14 Mar 2017 01:52:41 +0000 Received: from BN1BFFO11FD009.protection.gbl (2a01:111:f400:7c10::1:151) by BN6PR03CA0061.outlook.office365.com (2603:10b6:404:4c::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.961.17 via Frontend Transport; Tue, 14 Mar 2017 01:52:41 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1BFFO11FD009.mail.protection.outlook.com (10.58.144.72) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.961.10 via Frontend Transport; Tue, 14 Mar 2017 01:52:41 +0000 Received: from titan.ap.freescale.net ([10.192.208.233]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v2E1qc7Q026221; Mon, 13 Mar 2017 18:52:39 -0700 From: Zhao Qiang To: CC: , , Zhao Qiang Subject: [PATCH] ucc/hdlc: fix two little issue Date: Tue, 14 Mar 2017 09:38:33 +0800 Message-ID: <1489455513-19239-1-git-send-email-qiang.zhao@nxp.com> X-Mailer: git-send-email 2.1.0.27.g96db324 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131339299618098206; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39400400002)(39410400002)(39450400003)(39380400002)(39860400002)(39850400002)(39840400002)(2980300002)(1110001)(1109001)(339900001)(189002)(199003)(9170700003)(8656002)(53936002)(36756003)(6666003)(33646002)(106466001)(2351001)(5003940100001)(105606002)(4326008)(5660300001)(54906002)(47776003)(38730400002)(110136004)(305945005)(2906002)(8676002)(8936002)(50226002)(50986999)(6916009)(77096006)(81166006)(356003)(86362001)(189998001)(85426001)(48376002)(50466002)(104016004); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR03MB184; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; MLV:ovrnspm; MX:1; A:1; PTR:InfoDomainNonexistent; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD009; 1:V65BDr4fx1q9kRTBsyex5IfwRghkBycO4H9NxlZxQCoxCOO/vJw0pNTacYIphEY/oMg+rJFW5JMTCwqlTqTM7nkiCDQpq6MBk7QAe9pS0qtQbcubwdQG66TAC0NXmhy6oFFZK7MfnMRM4N3FPBWSWW7vJeEg6f1ODliF99vx8bWxuWtLra7O31BsxNwyUmxQknXKB5vokzvNnj/NmDy44WwPsGDiEIBJ/OLM7SKKmDP1D/Qerqt2ofCxNVOV24e8z7GuqNrQaGZw6nf5Mq9TCbFK+ti0G8pR2M07oUc4Og6OJcvlVroN5BRIX764v5RQIjC5AU/FohJre4mbP0XYyV5papvlBiC8Mh3eZmQdotYfnjKOJRmoKHxHV5OWkxoc7MPoT3Bn9RUeKLJhfcYOpEtS4BeP/e0y2rhuls426wQFQpLk7rVVLP2lBG3+Tr1mTSAYvKpsRsvek9lNzU9vpK/mSHzvMP4gS9wCLzhpQIjA66cMENcMHr1hNXr4lmORlSywEpuF5yl0tIik1Th7dvoLCAoaaLWQHmHuLZpyQkIEPz72eL0lmz69s7KNnvMNWzgm3EoQx97LOP877kNMTg+Cv0UcEx93+jlWU4P/3nQWkEj/2lc53EHckQLr7q/jlw7Eap3E7fmx7LoFsGdFff3UCsUTlrNIiY1XcAh6t3HBsf6i2aRgnuCzwKgOTGj6Y9a1lpZmX2pWKGbThGfXoQ== MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: ae707382-39ac-4644-aabd-08d46a7ccd3d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BLUPR03MB184; X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB184; 3:G/4hOxpkI78pWlPQb+oxiLP7DhxnK8GL2GQvRvpxS2UpG6C0cjKJVOTIiUyaRpdBYW+Nbi6AkGC28ZbrHZre2l2iG/JtwuROhFRQ95rIY+HjnkDwXG7OkIDl/C26VO6p1Xg8EFEENtODZZrRio5USwSUbdAE/ZemiXe5hk5IcR7LJepycnEBWF5WEeEYxfEUkc0LlZkaA/nL7zuIp+pp8nj+dKz0F0z5E95MeB+26NizkWu03hJwKfINY3M3dj6m1NnQyzkXxXqEop0yMKD/vyXd8/INIJvbWB12i627ZgAaMp4VNjLg7tx99lD5/dFh270S5p/ubEm0j63+2scozG2IVJjPAd0rAFOQoYzEw+NmwcOHd8kiaLt59ZVsH3sE; 25:wMxuL3JWCJHq1ADKj3bU/NjgFXOoyuRDgplfUWkb0doLh8g95VT3szfuR2NzBqGDpTDSLFPyTZFnlIGevtckIKUbs3jUIq+ISCnoD9HHNxZ7GDg0rklshp9omMiycOXotZI+0sG1lhCr/g0EIY1Z+hCtlBarpiVJ+DEgaa627uMrmpKqqWklCjr67di1/DDf2pR06r3C4XOfJvCGXdCIX++q33s3uIS8zSiNoVwciPZCkVKucMEdKqJsYHaAeOstb4OA3IzphO+diYiLyZ51NTT3ukJOFQhvncHDbEyLZHcEF8uBanB6IMpBb7xtZsxCf04iXABR5dV8WTqiYTav2VeMa0BFHEnPMPq7rkSklwxCaAH8gB6eODaT4G9E4hRRZ0Eo13uJu6BMvFMZ1QQvSH9yYB8lWbslssHdCYYtmpVjLorvfWjpu+0mBszWlw0r7iMI8zXFAy7uKh64qFV4LQ== X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB184; 31:ontx5wq/62aLZdEqzoYgP5Yju8+OOqMycLrjSlhl//82D1hMJtfpObjfgB7dpXVuR7ZDfqWrVB86sNwmkEFr/YoTEh+Zt/vwVOCI31iwRivP9oQgmiUcG4QPr78CxOVa93GbNEI8hIZqaMvzSxuupJLrXwS7uACY4BYFdM7MFodue2Lc+wLsf99ZOJc73q3pzrd36S1D6bi3q091j9aN2YA2jPVRzLO04pQUPGCHCK7WtFdqgdZgYenWFA6u15CYsxjnLC3aR4sSO2Y8rrcbkA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(13018025)(13023025)(13024025)(13015025)(5005006)(8121501046)(13017025)(3002001)(10201501046)(6055026)(6096035)(20161123561025)(20161123565025)(20161123559025)(20161123563025)(20161123556025); SRVR:BLUPR03MB184; BCL:0; PCL:0; RULEID:(400006); SRVR:BLUPR03MB184; X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB184; 4:GQBUlxSht3d3Fz3XkQVIMoxv4blC8EMRH+AXhyA1EsiaitFzA65BPXsQWzIB4FNq5t4qOGz0xVUxAoFVioGqLyj9aMZMwcs+fBW/DqMpMd3srFCVnTJb8P8SSU9jgGBPJQX4/sAdE0jTfoz7dGz5XV/Kw7pbIQlBDCyg2trF4llMC+R28eWSFTCX9KZTbQ4NODMkjS9eK/cw4CX0H7/VtGd3EqdUjttB3U/oNBnvXO2OVNlvOZMhhDy21NXtO9KxKUdp+CHIh26Pc2n2GlEIV+VeI64X6GdcWLQvqmoajk+3G9E2EKXGmo8rHCq8P8HHN+MB093I8pZiuFm9rxO6HKgHtLuN9QcRNfv7UzgkkYauUuKng75tuJxFcohxseeAO2Ykv2B8di/i+kxliDtrehKi2EQcDuMU7ytjVxhOCVm7Md/wfs9Hpb2XXQbTr/PQkyId/SbNEyBzxoL3ddrA7nFIT9PF+A3AY3FzMUKGdHIURThvO964qUoFFVNR4RgH3w579IV1p3dyv9nyaO4qtO5toIOPdHTV8ZNgRtxj/m/xC6a++wfwYdp1zjBgPClGaLMho2JBrHpRnQRt0ihJVTTr1wH2jpf5SzmkmHlz3QEZOv392x6Vv7iuRNBmctBaNYvW8KzWfKhF2jboHpRUuPQkRZv9V7K8IphoUbOsH2WR1Mg41vfwfEcgyPrj1wjSUafy3wEVKDJLHt1zRWGFNnL/RH9QPQjCVTCxJNXCBAlSA+4qNET0p2HP6CgpwBrc X-Forefront-PRVS: 02462830BE X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR03MB184; 23:9VhOm5P1zmuuPzuxC5E50LEnMW2qxVB9tJsD7uSViz?= =?us-ascii?Q?D1GeE3U86k/HH9YP+QAXhAxrE8oGhIEblvNlAL5EyzhGfqyrexPplfhVnHAr?= =?us-ascii?Q?IsqzMrEGLg6KHgA5NB7rQu22xFbi6G2Y7fd4B+601msLJb5YnhiUP+u6e3cC?= =?us-ascii?Q?XEq6+c/X4g6Rx/xLS6laXh/yX5TtZCrE8af8BCIEhIbpdUxw7tCnvj46OiQC?= =?us-ascii?Q?tDJ4cfO4r4W0dNV6+NgjXuC6zI3t3qbIl+2kGcYWpaMhuZR8LlrSmt9i6CT4?= =?us-ascii?Q?0kehdYqOVnLcIX3YAr/4RQRqWG1p1sfKtPHiyvIMDQnph4wdrraarvyEPDLg?= =?us-ascii?Q?QbX8YhLUYL9x0xLGp3gQWTkNCl0QGdszCpd/oGqFDv+JUrGI2tQeUTEr/rby?= =?us-ascii?Q?af9DwLX3nns29yd3j91b4pKeaSksP0yZcG+llPWDlVltMnxjxy39SZioXKTc?= =?us-ascii?Q?1d1520a6qH983DyLmA8lcrWAyotxbXeoPaiOKVINmgKJZ1iC4MS2E4IDA3g6?= =?us-ascii?Q?GiiWcckGD3y7V4d9Dgf4JZF26WSIQ7cJSuyiE75MNq0Na7e5HqCOg1xZ06ux?= =?us-ascii?Q?T9Dwd/9nxAu13W9pCN1AG2/CzRF80SAUm8t2dOTAtKIWz86vKyFFie9vkhXj?= =?us-ascii?Q?A2aCx9yddEPuJrrnJpzgyObuiOECCq6d/ospJBBbkvTCBfxJ6zfwyJAfVSrv?= =?us-ascii?Q?6vP4L8XyavYGOl6+6byq0KlZroVLVvbcdHUj4zA01KX9ElTUae2uj6jY8NKH?= =?us-ascii?Q?qESfpeGKtheqKjk8JyNL2jWXmPrU5FjPGhJpiLOXCnVzy0v64dS82RbaFJPn?= =?us-ascii?Q?lkAbBHfR5plvgHt5PoQTsUYd5egf7GIPTURfNC5m/lUfdwvbtgIjW2vVuvu3?= =?us-ascii?Q?rBufru6FOSeSyS0WAu3dyi6CY5KO/p9Pt1pugJon6LFoPRHcwC59N3hbbJCY?= =?us-ascii?Q?lX6V2/xVQEVEqVGjXUPY3zbtEyiVrRjwJOMOaiPow4R8YwJ0sg1xCDjIkK/X?= =?us-ascii?Q?toS/m5zTvGnh9zdInatIFGV4mDpFj9AWtqCLsY4mut8TUujp0TM5lXClAEiX?= =?us-ascii?Q?Th3JnBUexBbHiE2l+45NS4UP1OsLrtmyqfX8WDgogOrGYUJjMrVFMxke6V/x?= =?us-ascii?Q?bUu21UhVC4o0c2BPlMIlXHitgJcAYsCiduJrpFVoQd5PtybL0bVQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB184; 6:MljxkAtBWppGbFfjLxyzVVYhLGMtIlHvKCTpFvKAs3x29R8AA/V7aL/tJQZR/KB0J3bmFetrepti7CYxVhaiCNFfc07HAEEZD0QDgDn/ESyYukPf4MuHUDiawmKxj6KECCb9k41WU66nSG+lZsFL0IQ7KVZO7rpa8HYmiFjeMvnYcAxk31Uw51/jmGwssIA1qgya7qJVDn6RQ8gy21MaBLvUtXVf7HRrZ/dZcE0tcikfo+yi1jRFhpIpBKUi5vcTO3sPDSmn0t35t20P9qugMXSs46j0DixuGTv+mq/pqU0ecl6qlF7rPGr8TkqNEeptXcfR29Nd2kDqIBdN0XawAQiij+UcxNg5OmPKYjylaTxy955cRyZ3SblHspkq7s+dV9gQuJFtE5IylJLDLc21uGsO6nTcCELPk2+fsoCq6Ns=; 5:crCJJVKkAxDjEAyb/+F8Fc8QcfrnT8BG86W0iEDU4nlRAj1SbPZuF6BS1A9KP6+gE8objc5fWV+NIzRI3Hnmdt2Bytmq8XvoPUjzqe4wHQGPSBNnsOeSt5tF2NQprjdNOS5OlCZj77KcOHbVHks5xc6eK6KHtrK730opb2eFYRF8xmIhsl4+pqtTRw1lfXHP; 24:6kfGFNq/BQMbmSl2yE3C9qkYvNmjE3zqHmEmpeoOMwDMGO4DSQR92b8zhChAiD/xxBk0AFpa2lCgqWvqxNJS9lObMNzM6HEFLmRMle868So= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB184; 7:86VY5MDmZ73pLM3EJ1d02D6i5s89lpv5DRzTOhLrlC5JURx2vSHwMRVIsU7tCOHAeuJ0j+h1zkF8+4LYOaS2ijPRcV3Od3NpiG8J8wX2INmbso1S8rQ0OluQDUqYly3amYvspBKj4JS3SxmWspD/gykbfOhfjxlS7OIOo5hackX0iRCyKBRnWRUQIttwUz/UmJG452LfuD4YHi5SUJeznA+cqAhSRr9aIYn0LV98c0BMV1JptcSifwJqqrcKgrZUrVIWPdMXSWEtJB4PgJG9kpg1wJnLtogUK2axFd1dVNb5akXih1oijwE5KBeAsE4rk00Gk82y4AwddWkumAHzfQ== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2017 01:52:41.6070 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB184 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org 1. modify bd_status from u32 to u16 in function hdlc_rx_done, because bd_status register is 16bits 2. write bd_length register before writing bd_status register Signed-off-by: Zhao Qiang --- drivers/net/wan/fsl_ucc_hdlc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c index a5045b5..6742ae6 100644 --- a/drivers/net/wan/fsl_ucc_hdlc.c +++ b/drivers/net/wan/fsl_ucc_hdlc.c @@ -381,8 +381,8 @@ static netdev_tx_t ucc_hdlc_tx(struct sk_buff *skb, struct net_device *dev) /* set bd status and length */ bd_status = (bd_status & T_W_S) | T_R_S | T_I_S | T_L_S | T_TC_S; - iowrite16be(bd_status, &bd->status); iowrite16be(skb->len, &bd->length); + iowrite16be(bd_status, &bd->status); /* Move to next BD in the ring */ if (!(bd_status & T_W_S)) @@ -457,7 +457,7 @@ static int hdlc_rx_done(struct ucc_hdlc_private *priv, int rx_work_limit) struct sk_buff *skb; hdlc_device *hdlc = dev_to_hdlc(dev); struct qe_bd *bd; - u32 bd_status; + u16 bd_status; u16 length, howmany = 0; u8 *bdbuffer; int i;